Skip to content

Improved admin zone#305

Open
lukaskett wants to merge 6 commits intomainfrom
feature/admin-zone-pagination
Open

Improved admin zone#305
lukaskett wants to merge 6 commits intomainfrom
feature/admin-zone-pagination

Conversation

@lukaskett
Copy link
Copy Markdown
Contributor

Summary

Added pagination to the admin zone and fixed issue with updating original author

Checklist

  • I linked the related issue or explained why none is needed.
  • I ran the relevant checks for this change.
  • I updated documentation or changelog entries when needed.
  • By submitting this pull request, I agree to the terms in CLA.md in the
    repository root.

}

const { userId } = ownership;
const { userId, event: existingEventOwnership } = ownership;
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not able to track who edited the event as the last one when admin can update it as well.

Only the timestamp of the change is stored without a relation to the author.

We could extend the event table and add columns authorIdCreated and authorIdEdited instead of just authodId.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you've overcomplicated things—wouldn't it be enough to just remove the authorId from the UPDATE statement?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, when you add more roles that will enable e.g. sharing event for the users from the same club, it could be useful.

But just removing authorId makes sense and we can extend it later.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add competitor search.

It is possible to prolink user name on the event detail tab with the users table in admin zone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants