Skip to content

fix(ci): merge release + Docker build into one job#28

Merged
KailasMahavarkar merged 1 commit intomainfrom
fix/release-and-publish-combined
Apr 10, 2026
Merged

fix(ci): merge release + Docker build into one job#28
KailasMahavarkar merged 1 commit intomainfrom
fix/release-and-publish-combined

Conversation

@KailasMahavarkar
Copy link
Copy Markdown
Collaborator

Problem

`GITHUB_TOKEN`-created releases do not re-trigger the `release:` workflow event — GitHub blocks recursive workflow triggers. So `build-and-push-image` (which was gated on `github.event_name == 'release'`) never fired after the auto-release job ran.

Result: `v1.1.0` was released but no Docker image was pushed to ghcr.io.

Fix

Merge release creation and Docker build into a single `release-and-publish` job. Both the `gh release create` and `docker/build-push-action` steps are gated on `steps.check.outputs.new == 'true'`, so they only execute when the version in `package.json` is new.

Also removes the now-unused `release: types: [published]` trigger.

Flow after this PR

```
push to main (version bumped) → verify → release-and-publish:
├── gh release create v1.x.x
├── docker login ghcr.io
├── extract metadata (tags)
└── build + push :v1.x.x :latest

push to main (no version bump) → verify → release-and-publish:
└── (all steps skipped, tag already exists)

pull_request → verify only
```

🤖 Generated with Claude Code

GITHUB_TOKEN-created releases do not re-trigger the release: workflow
event (GitHub blocks this to prevent loops), so build-and-push-image
never fired after auto-release.

Merges release creation and Docker build into a single
release-and-publish job. Both steps are gated on
steps.check.outputs.new == 'true' so they only run when the version
in package.json is new. Also removes the release: trigger from the
workflow since it is no longer needed.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@KailasMahavarkar KailasMahavarkar merged commit d2569cd into main Apr 10, 2026
4 checks passed
@KailasMahavarkar KailasMahavarkar deleted the fix/release-and-publish-combined branch April 10, 2026 11:59
KailasMahavarkar added a commit that referenced this pull request Apr 14, 2026
GITHUB_TOKEN-created releases do not re-trigger the release: workflow
event (GitHub blocks this to prevent loops), so build-and-push-image
never fired after auto-release.

Merges release creation and Docker build into a single
release-and-publish job. Both steps are gated on
steps.check.outputs.new == 'true' so they only run when the version
in package.json is new. Also removes the release: trigger from the
workflow since it is no longer needed.

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant