Skip to content

Add the --sort-baseline option to the docs #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

wouterdb
Copy link
Contributor

Hi,

I added the --sort-baseline option to the docs.

(I intended to implement it myself, but it turned out to already exist)

Thank you for creating this great tool (with its super useful documentation).

Wouter

Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for mypy-baseline ready!

Name Link
🔨 Latest commit 5a3085d
🔍 Latest deploy log https://app.netlify.com/sites/mypy-baseline/deploys/67b6e73821c5ef0008e66b01
😎 Deploy Preview https://deploy-preview-26--mypy-baseline.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@orsinium
Copy link
Member

Thank you! The Configuration page is a better place to document it. It documents all other flags and config options.

@wouterdb
Copy link
Contributor Author

Should I revert the changes on the sync file?

@orsinium
Copy link
Member

Should I revert the changes on the sync file?

Yeah, either keep the original version as-is or add to it a mention of the option. The advise to run sync on conflict should stay, it's a valid strategy in any case of git conflicts, even if you use the sort option. Also, my advise would be to add it into the config file rather than as a CLI flag.

@orsinium orsinium merged commit db51332 into orsinium-labs:master Feb 20, 2025
6 checks passed
@orsinium
Copy link
Member

Thank you!

@wouterdb wouterdb deleted the add_sort_baseline_to_docs branch February 20, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants