feat: redirect to OIDC providers only once in registration flows#4064
Open
David-Wobrock wants to merge 1 commit intoory:masterfrom
Open
feat: redirect to OIDC providers only once in registration flows#4064David-Wobrock wants to merge 1 commit intoory:masterfrom
David-Wobrock wants to merge 1 commit intoory:masterfrom
Conversation
fb74bf8 to
350b1db
Compare
2a5c310 to
04d1348
Compare
ac66d6b to
296907b
Compare
09433f9 to
2ca9f28
Compare
2ca9f28 to
e67a990
Compare
e67a990 to
7eb1eac
Compare
This was referenced Jan 28, 2025
7eb1eac to
8a32254
Compare
|
Can this get attention? |
8a32254 to
26610db
Compare
test(e2e): ensure there is only one OIDC redirect Co-authored-by: Jakub Fijałkowski <jakub.fijalkowski@leancode.pl>
26610db to
7a8dbf7
Compare
|
This seems like a very useful addition. Any chance it could get reviewed in the near term? |
|
@aeneasr Any plans to merge this in the near future? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing a social sign-in, but some required identity fields are not provided by the social provider, Kratos switches to a registration flow in order to fill the missing data.
As #2863 describes it, the idea is that instead of redirecting back to the social provider when submitting the registration form, we handle the registration directly by Kratos and the previously stored OIDC data.
The main rationale is that it feels very unusual for users to select twice your Google account (for instance) during social sign-in. Or even more if more errors occur on the registration form.
Three steps fix this issue:
Related issue(s)
Fixes #2863
Core code based on #3416
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments