Added Xilinx BRAM Macro and changes to kernel #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e2e569a.
stevehoover
requested changes
Aug 23, 2021
| static const int DATA_WIDTH_WORDS = DATA_WIDTH_BYTES / 4; // | ||
| static const int DATA_WIDTH_BITS = DATA_WIDTH_BYTES * 8; // 512 bits | ||
| static const int verbosity = 0; // 0: no debug messages; 10: all debug messages. | ||
| static const int verbosity = 10; // 0: no debug messages; 10: all debug messages. |
| class Socket(): | ||
|
|
||
| VERBOSITY = 0 # 0-10 (quiet-loud) | ||
| VERBOSITY = 10 # 0-10 (quiet-loud) |
|
|
||
| $(DEST_DIR)/$(KERNEL_EXE).xclbin: $(XO_FILE) | ||
| cd $(DEST_DIR); $(XOCC) -g --platform $(AWS_PLATFORM) --target $(BUILD_TARGET) --link -O quick --save-temps $(REPORT) --kernel $(KERNEL_NAME) ../../$(XO_FILE) $(KERNEL_LDCLFLAGS) $(KERNEL_FLAGS) $(KERNEL_ADDITIONAL_FLAGS) --output $(KERNEL_EXE).xclbin | ||
| cd $(DEST_DIR); $(XOCC) -g --platform $(AWS_PLATFORM) --profile_kernel data:all:all:all --target $(BUILD_TARGET) --link --optimize 2 --save-temps $(REPORT) --kernel $(KERNEL_NAME) ../../$(XO_FILE) --output $(KERNEL_EXE).xclbin |
There was a problem hiding this comment.
Is this how we want to commit? Profiling works? What about the _FLAGS variables you removed?
| #hw and hw_emu target | ||
| $(DEST_DIR)/$(HOST_EXE): $(HOST_SRC) $(HOST_HDRS) | ||
| mkdir -p $(DEST_DIR) | ||
| cp sdaccel.ini $(DEST_DIR) |
There was a problem hiding this comment.
Here and several other places.
| --memory_port_data_width $(KERNEL_NAME):512 \ | ||
|
|
||
| KERNEL_ADDITIONAL_FLAGS= | ||
| KERNEL_ADDITIONAL_FLAGS= --xp vivado_prop:run.my_rm_synth_1.{STEPS.SYNTH_DESIGN.ARGS.FLATTEN_HIERARCHY}={rebuilt} \ |
There was a problem hiding this comment.
Are these all generally desired? Might be good to have some comments.
| @@ -0,0 +1,6 @@ | |||
| [Debug] | |||
There was a problem hiding this comment.
Should this be in /framework?
| // (Finally, now in TLV-land) | ||
|
|
||
| // The hookup of kernel module SV interface signals to TLV signals following flow library conventions. | ||
| \TLV tlv_wrapper(|_in, @_in, |_out, @_out, /_trans) |
There was a problem hiding this comment.
Can this be included from somewhere else?
| // This must be defined prior to any \TLV region, so \TLV macro syntax cannot be used - just raw m4. | ||
| // $1: kernel name | ||
| m4_define(['m4_kernel_module_def'], [' |
There was a problem hiding this comment.
Can this be included from elsewhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GSoC final Pull Request