Open
Conversation
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Reverting the escaped variables back to direct interpolation in
ci/aws.shreintroduces the risk of Jenkins/Groovy baking secrets into logs/config; consider keeping the escaping while still adjusting the EUSC-specific behavior you need to revert. - Instead of fully removing the
STS_ENDPOINTlogic and EUSC-specific endpoints inaws_config_builder.py, consider feature-flagging or gating the EUSC behavior so you can temporarily disable it for validation without breaking that region for future runs. - You added
JIRA_PATto the container environment inci/aws.shbut it is not used bycloud-image-val.pyin this change set; either wire it through where needed or drop it from this PR to avoid confusion about unused secrets.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Reverting the escaped variables back to direct interpolation in `ci/aws.sh` reintroduces the risk of Jenkins/Groovy baking secrets into logs/config; consider keeping the escaping while still adjusting the EUSC-specific behavior you need to revert.
- Instead of fully removing the `STS_ENDPOINT` logic and EUSC-specific endpoints in `aws_config_builder.py`, consider feature-flagging or gating the EUSC behavior so you can temporarily disable it for validation without breaking that region for future runs.
- You added `JIRA_PAT` to the container environment in `ci/aws.sh` but it is not used by `cloud-image-val.py` in this change set; either wire it through where needed or drop it from this PR to avoid confusion about unused secrets.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to unblock the package validation.
DO NOT MERGE this one, otherwise our Jenkins won't work for EUSC region