Skip to content

Comments

[DO NOT MERGE] Revert EUSC changes#516

Open
alexxa wants to merge 10 commits intoosbuild:mainfrom
alexxa:revert
Open

[DO NOT MERGE] Revert EUSC changes#516
alexxa wants to merge 10 commits intoosbuild:mainfrom
alexxa:revert

Conversation

@alexxa
Copy link
Collaborator

@alexxa alexxa commented Feb 3, 2026

to unblock the package validation.

DO NOT MERGE this one, otherwise our Jenkins won't work for EUSC region

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Reverting the escaped variables back to direct interpolation in ci/aws.sh reintroduces the risk of Jenkins/Groovy baking secrets into logs/config; consider keeping the escaping while still adjusting the EUSC-specific behavior you need to revert.
  • Instead of fully removing the STS_ENDPOINT logic and EUSC-specific endpoints in aws_config_builder.py, consider feature-flagging or gating the EUSC behavior so you can temporarily disable it for validation without breaking that region for future runs.
  • You added JIRA_PAT to the container environment in ci/aws.sh but it is not used by cloud-image-val.py in this change set; either wire it through where needed or drop it from this PR to avoid confusion about unused secrets.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Reverting the escaped variables back to direct interpolation in `ci/aws.sh` reintroduces the risk of Jenkins/Groovy baking secrets into logs/config; consider keeping the escaping while still adjusting the EUSC-specific behavior you need to revert.
- Instead of fully removing the `STS_ENDPOINT` logic and EUSC-specific endpoints in `aws_config_builder.py`, consider feature-flagging or gating the EUSC behavior so you can temporarily disable it for validation without breaking that region for future runs.
- You added `JIRA_PAT` to the container environment in `ci/aws.sh` but it is not used by `cloud-image-val.py` in this change set; either wire it through where needed or drop it from this PR to avoid confusion about unused secrets.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants