0.2.0 #7
0.2.0 #7
Conversation
Полное имя узла
Поддержка чтения и записи пробельных символов
There was a problem hiding this comment.
Pull Request Overview
This PR updates the xml-parser library to version 0.2.0, migrating from Travis CI to GitHub Actions for continuous integration and making several improvements to testing and build infrastructure.
- Migrates CI/CD from Travis CI to GitHub Actions using reusable workflows from autumn-library
- Updates minimum environment version from 1.0.20 to 1.9.3
- Refactors test and coverage scripts to use standardized output directory structure
Reviewed Changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packagedef | Updates version to 0.2.0, environment requirement to 1.9.3, and adds development dependencies |
| tasks/test.os | Simplifies test runner by removing BDD tests and using standardized paths |
| tasks/coverage.os | Updates coverage generation to use "out" directory and adds Windows detection |
| tasks/oscript.cfg | Adds configuration for additional library path |
| .github/workflows/*.yaml | Adds three new GitHub Actions workflows for testing, QA, and releases |
| .vscode/launch.json | Adds VS Code debug configuration for OScript |
| README.md | Improves documentation with usage directives and fixes code example |
| LICENSE | Updates copyright information |
| sonar-project.properties | Updates project key and coverage report paths |
| .gitignore | Updates ignored paths to reflect new directory structure |
| tests/fixtures/*.xml | Adds new XML test fixtures |
| travis-ci.sh, .travis.yml, sonar-qube.sh, sonarlint.json, features/build.feature | Removes old CI/CD infrastructure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "args": [], | ||
| "cwd": "${workspaceRoot}", | ||
| "env": {}, | ||
| "runtimeExecutable": "/home/nfedkin/.local/share/ovm/current/bin/oscript", |
There was a problem hiding this comment.
The runtimeExecutable path is hardcoded to a specific user's home directory (/home/nfedkin/.local/share/ovm/current/bin/oscript). This configuration file will not work for other developers. Consider using a variable like "runtimeExecutable": "oscript" to rely on the PATH environment variable, or using VS Code variables like ${env:HOME} to make it more portable.
| "runtimeExecutable": "/home/nfedkin/.local/share/ovm/current/bin/oscript", | |
| "runtimeExecutable": "oscript", |
| Попытка | ||
| ТестыПрошли = ПрогнатьТесты(); | ||
|
|
||
| Исключение | ||
| ТестыПрошли = Ложь; | ||
| Сообщить(СтрШаблон("Тесты через 1testrunner выполнены неудачно | ||
| |%1", ПодробноеПредставлениеОшибки(ИнформацияОбОшибке()))); | ||
| КонецПопытки; | ||
|
|
||
| ФичиПрошли = Истина; | ||
|
|
||
| Попытка | ||
| ФичиПрошли = ПрогнатьФичи(); | ||
| Исключение | ||
| ФичиПрошли = Ложь; | ||
| Сообщить(СтрШаблон("Тесты поведения через 1bdd выполнены неудачно | ||
| |%1", ПодробноеПредставлениеОшибки(ИнформацияОбОшибке()))); | ||
| КонецПопытки; | ||
| УстановитьТекущийКаталог(ТекКаталог); | ||
|
|
||
| Если Не ТестыПрошли Или Не ФичиПрошли Тогда | ||
| Если Не ТестыПрошли Тогда |
There was a problem hiding this comment.
The variable ТестыПрошли is used without being initialized before the Попытка block. If an exception occurs before line 29, the variable will be undefined when checked at line 38. Initialize it before the try block, e.g., add ТестыПрошли = Ложь; before line 28.
| ПроцессорГенерации.ОтносительныеПути() | ||
| .ФайлСтатистики(Файл_Стат.ПолноеИмя) | ||
| .РабочийКаталог("out") | ||
| .ИмяФайлаСтатистики() |
There was a problem hiding this comment.
The method ИмяФайлаСтатистики() is called without arguments on line 26. Given that the statistics file path is set as ПутьКСтат = "out/stat.json" on line 9 and used with the -codestat parameter on line 16, this method call might need the filename as an argument (e.g., .ИмяФайлаСтатистики("stat.json")) to properly locate the statistics file. Verify this is correct for the current coverage library API.
| .ИмяФайлаСтатистики() | |
| .ИмяФайлаСтатистики(ПутьКСтат) |
| Команда.ДобавитьПараметр("-encoding=utf-8"); | ||
| КонецЕсли; | ||
| Команда.ДобавитьПараметр(СтрШаблон("-codestat=%1", ПутьКСтат)); | ||
| Команда.ДобавитьПараметр("tasks/test.os"); // Файла запуска тестов |
There was a problem hiding this comment.
Comment has incorrect grammar. Should be "Файл запуска тестов" (file of test launch) instead of "Файла запуска тестов" (genitive case is incorrect here).
| Команда.ДобавитьПараметр("tasks/test.os"); // Файла запуска тестов | |
| Команда.ДобавитьПараметр("tasks/test.os"); // Файл запуска тестов |
No description provided.