Skip to content

Conversation

@mbuechse
Copy link
Contributor

@mbuechse mbuechse commented Sep 1, 2023

Resolves #639 and includes many minor improvements (including a somewhat alternative approach to #633).

Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>
Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>
Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>
Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>
Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>
Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>
Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>
Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>
Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>
Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>
@mbuechse mbuechse requested a review from berendt September 1, 2023 21:16
@berendt berendt requested review from gndrmnn and lindenb1 September 6, 2023 08:24
@berendt berendt added the SCS Sovereign Cloud Stack label Sep 6, 2023
@mbuechse
Copy link
Contributor Author

mbuechse commented Sep 6, 2023

To the reviewers: I tried to make small and self-contained commits. If the total change seems overwhelming, it could be worthwhile to look at each commit in isolation.

@gndrmnn
Copy link
Contributor

gndrmnn commented Sep 6, 2023

recheck

Copy link
Contributor

@gndrmnn gndrmnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
By the way, #627 will reduce the complexity even further as we pre-compute sha512 sums instead of relying on upstream hashes. (We will rebase this change into our branch soon)

Copy link
Contributor

@lindenb1 lindenb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@berendt berendt merged commit 49c7e12 into main Sep 8, 2023
@berendt berendt deleted the issue/639 branch September 8, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SCS Sovereign Cloud Stack

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolve latest URL in update script

5 participants