Fix: Missing Public Key and Incorrect Run Variable#34
Open
josiahls wants to merge 9 commits intoosrf:masterfrom
Open
Fix: Missing Public Key and Incorrect Run Variable#34josiahls wants to merge 9 commits intoosrf:masterfrom
josiahls wants to merge 9 commits intoosrf:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First: Fixed is related to: #32 . For me the docker file would fail to install due to a missing key.
Second: Fixed
run_container.bash.Define DISPLAY_PARAMS:
But in the run section:
Where is
DISPLAY_PARAMS? I think it was meant to beDOCKER_DISPLAY_PARAMS?My solution is add
DISPLAY_PARAMSas an arguement.