Open
Conversation
Member
|
I'm not a maintainer, but this sounds like a useful feature. It would probably be good if you could add some tests for it, and sign-off your commit(s) ( |
Signed-off-by: Dominik Authaler <dominik.authaler@uni-ulm.de>
Signed-off-by: Dominik Authaler <dominik.authaler@uni-ulm.de>
Signed-off-by: Dominik Authaler <dominik.authaler@uni-ulm.de>
Signed-off-by: Dominik Authaler <dominik.authaler@uni-ulm.de>
1d1ab26 to
2421d99
Compare
Author
|
Done, unfortunately I am not even able to request a review from someone. I am not sure whether this repository is still maintained, given the fact that your two pull requests are open for over a year now and didn't receive any kind of response. |
Member
|
Thanks for adding the test! Yeah, I think this repository was more of an experiment/proof-of-concept. I'll ask around. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
first of all thanks for this useful library!
In our use-case we discovered the caveat that converting rather large messages into their corresponding YAML format can take a considerable amount of time. Since we've been only interested in a few selected members of the messages (mainly 'header' information describing the detailed structure of large data blocks), we added a small utility function for converting those message members into their corresponding YAML-format.