Correctly format amounts of less than 10 cents#591
Open
FriesischScott wants to merge 1 commit intooss-apps:mainfrom
Open
Correctly format amounts of less than 10 cents#591FriesischScott wants to merge 1 commit intooss-apps:mainfrom
FriesischScott wants to merge 1 commit intooss-apps:mainfrom
Conversation
Amounts of less than 10 cents where incorrectly formatted such that one cent would render as 0.1. The issue is fixed by padding the string with the appropriate number of zeros. I've also added a corresponding test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Amounts of less than 10 cents are currently formatted incorrectly. For example 1 cent (represented as
1n) is rendered as$0.1.When
simplifyDeptsresults in very small amounts they render incorrectly and do not add up to the correct depts anymore.The issue is fixed by padding the string with the appropriate number of zeros.
I've also added a corresponding test.
Checklist
CONTRIBUTING.mdin its entirety