🐛 Fix Code-Review check for projects using Reviewed-by in commit messages#4984
Open
LoveChauhan-18 wants to merge 3 commits intoossf:mainfrom
Open
🐛 Fix Code-Review check for projects using Reviewed-by in commit messages#4984LoveChauhan-18 wants to merge 3 commits intoossf:mainfrom
LoveChauhan-18 wants to merge 3 commits intoossf:mainfrom
Conversation
…exts Signed-off-by: Love Kumar Chauhan <lovechauhan6564@gmail.com>
The GitHub Search API can return a 422 Validation Failed error for public repositories that are not yet indexed. This was causing an internal error in Scorecard's Dependency-Update-Tool check. This fix catches the 422 error and returns an empty list of commits, allowing the check to proceed without a hard failure. Fixes ossf#4352 Signed-off-by: Love Kumar Chauhan <lovechauhan6564@gmail.com>
…ages Signed-off-by: Love Kumar Chauhan <lovechauhan6564@gmail.com>
LoveChauhan-18
requested review from
AdamKorcz and
jeffmendoza
and removed request for
a team
dosubot
bot
added
the
size:L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
(Bug fix)
What is the current behavior?
The
Code-Reviewcheck incorrectly marks commits as unreviewed for projects (likeopenssl/openssl) that perform local merges and direct pushes, bypassing standard GitHub PR associations.What is the new behavior (if this is a feature change)?**
The
Code-Reviewcheck now recognizesReviewed-by:signatures directly in git commit messages. It extracts the reviewer identities using regex and maps them to standard Review objects, which are then evaluated by thecodeApprovedprobe. This includes association mapping to prevent self-approval vulnerabilities.Which issue(s) this PR fixes
Fixes #4730
Special notes for your reviewer
I have updated the checks.yaml metadata and regenerated the
checks.mddocumentation to ensure the new capability is documented.Does this PR introduce a user-facing change?
Yes.