Skip to content

Addition of cell slot type text to weapons dropdown names #1

Open
rampeara wants to merge 1 commit intoosthoma:masterfrom
rampeara:add_cellslot_text_to_weapon_ddl
Open

Addition of cell slot type text to weapons dropdown names #1
rampeara wants to merge 1 commit intoosthoma:masterfrom
rampeara:add_cellslot_text_to_weapon_ddl

Conversation

@rampeara
Copy link
Copy Markdown

This change is to easily identify weapons by specific slot type (with code optimisation on affected part). I added this change as when I was making a build, I found myself often going back and forth in the weapons and armour list to check which slot type each item had. By adding the cellslot type information in the name (truncated to first 4 characters for each slot type, e.g. [Slot(s): Tech, Util]) we can easily choose items per slot type requirements for a build.

WARNING: This was not tested. I could not set a local environment yet but am fairly confident that it should work on your localhost. I will be adding the same for armour if this gets added to the site.

…fy weapons by specific slot type (with code optimisation on affected part)
@osthoma
Copy link
Copy Markdown
Owner

osthoma commented Jun 29, 2018

Hi,

while I like the idea of showing cell slots on selection I think adding [Slots: XXX, XXX] adds too much clutter to the dropdown. I'll implement it using simple icons like a circled T for Technique etc., this way it should provide the same info using less space.

@rampeara
Copy link
Copy Markdown
Author

rampeara commented Jul 2, 2018

Hi,

I agree, that's a better alternative. An icon that on hover shows the full name is best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants