Addition of cell slot type text to weapons dropdown names #1
Open
rampeara wants to merge 1 commit intoosthoma:masterfrom
Open
Addition of cell slot type text to weapons dropdown names #1rampeara wants to merge 1 commit intoosthoma:masterfrom
rampeara wants to merge 1 commit intoosthoma:masterfrom
Conversation
…fy weapons by specific slot type (with code optimisation on affected part)
Owner
|
Hi, while I like the idea of showing cell slots on selection I think adding [Slots: XXX, XXX] adds too much clutter to the dropdown. I'll implement it using simple icons like a circled T for Technique etc., this way it should provide the same info using less space. |
Author
|
Hi, I agree, that's a better alternative. An icon that on hover shows the full name is best. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is to easily identify weapons by specific slot type (with code optimisation on affected part). I added this change as when I was making a build, I found myself often going back and forth in the weapons and armour list to check which slot type each item had. By adding the cellslot type information in the name (truncated to first 4 characters for each slot type, e.g. [Slot(s): Tech, Util]) we can easily choose items per slot type requirements for a build.
WARNING: This was not tested. I could not set a local environment yet but am fairly confident that it should work on your localhost. I will be adding the same for armour if this gets added to the site.