fix: mock dedup check in existing compilation tests

[zonk1024]

Problem

PR #582 added _find_similar_article() inside compile_article(), which calls generate_embedding() — a real API call. The existing tests in tests/core/test_compilation.py had no mock for this path, so they would fail in CI environments without a live OpenAI key (currently passing only because the exception is silently swallowed by the try/except guard in _find_similar_article).

Fix

Added a single module-level autouse fixture in tests/core/test_compilation.py:

@pytest.fixture(autouse=True)
def _no_dedup(monkeypatch):
    """Disable dedup check in compilation tests (tested separately in test_compilation_dedup.py)."""
    async def _no_match(*args, **kwargs):
        return None
    monkeypatch.setattr("valence.core.compilation._find_similar_article", _no_match)

This patches out _find_similar_article for every test in the file, making the intent explicit and removing the silent dependency on error-swallowing behaviour. Dedup logic is already covered by test_compilation_dedup.py.

Verification

python -m pytest tests/core/test_compilation.py -q   # 55 passed
python -m pytest tests/ -q                           # 1713 passed, 10 skipped

Changes

• tests/core/test_compilation.py — add _no_dedup autouse fixture (+21 lines, no test logic changed)

[Copilot]

Pull request overview

This PR makes the existing compilation tests independent of the dedup-on-compile path introduced in PR #582 by globally patching _find_similar_article() in tests/core/test_compilation.py, preventing real embedding API calls during this test suite.

Changes:

• Add a module-level autouse fixture that monkeypatches valence.core.compilation._find_similar_article to always return None.
• Document why dedup is suppressed in these tests and point to test_compilation_dedup.py for dedup coverage.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

from valence.core.compilation import (...) is placed after executable code (the autouse fixture), which triggers Ruff/pycodestyle E402 (module level import not at top of file) and will fail CI. Please move this import block up with the other imports (above the fixture), or add an explicit # noqa: E402 (reordering is preferable).