Skip to content

Fix HTTP 500 when empty response (Issue: #57) #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
everaldorodrigo wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix HTTP 500 when empty response (Issue: #57) #97

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fea63a
Fix HTTP 500 when empty response.
everaldorodrigo Jul 19, 2023
3f0007a
Force HTTP 400 when 'mutations' param has ';' instead of 'AND'.
everaldorodrigo Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion web/handlers/genomics/lineage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from .util import create_nested_mutation_query, calculate_proportion, parse_location_id_to_query, get_total_hits

import re
from tornado.web import HTTPError

class LineageByCountryHandler(BaseHandler):

Expand Down Expand Up @@ -288,6 +289,8 @@ class MutationsByLineage(BaseHandler):
def _get(self):
query_location = self.get_argument("location_id", None)
query_mutations = self.get_argument("mutations", None)
if ";" in query_mutations:
raise HTTPError(400)
query_pangolin_lineage = self.get_argument("pangolin_lineage", None)
query_mutations = [muts.split(",") for muts in query_mutations.split(" AND ")] if query_mutations is not None else []
query_frequency_threshold = self.get_argument("frequency", None)
Expand Down Expand Up @@ -343,7 +346,8 @@ def _get(self):
df_response.loc[:, "proportion"] = prop[0]
df_response.loc[:, "proportion_ci_lower"] = prop[1]
df_response.loc[:, "proportion_ci_upper"] = prop[2]
df_response = df_response[df_response["proportion"] >= query_frequency_threshold]
if "proportion" in df_response:
df_response = df_response[df_response["proportion"] >= query_frequency_threshold]
results[",".join(muts)] = df_response.to_dict(orient="records")
resp = {"success": True, "results": results}
return resp