Gate tui-stories Bun import workaround by runtime version#635
Draft
schickling-assistant wants to merge 4 commits intomainfrom
Draft
Gate tui-stories Bun import workaround by runtime version#635schickling-assistant wants to merge 4 commits intomainfrom
schickling-assistant wants to merge 4 commits intomainfrom
Conversation
Collaborator
Author
|
Holding this PR until nixpkgs ships a stable Bun with the module-loader fix from oven-sh/bun#29393 (Bun >= 1.3.14). Current state:
Unblock checklist:
Posted on behalf of @schickling
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@overeng/tui-storieson Bun1.3.14+and non-Bun runtimes.1.3.14-canary.1+ca9e0896c, the post-module-loader-rewrite build that fixes Concurrent dynamic import with top level await trigger temporal dead zone oven-sh/bun#20489. There is no stablebun-v1.3.14GitHub release asset yet; the overlay pins the canary assets by fixed-output hashes.<1.3.14.Benchmark
Synthetic import-scheduler benchmark on local Node
v24.14.0, using 48 independent ESM modules with 35ms top-level await each, 7 rounds:1714.9ms42.2ms40.6x1672.7msBun verification
1.3.11.#bun:1.3.14-canary.1+ca9e0896c.#bun: five concurrent imports all resolved initialized exports.Validation
nix build .#bun --print-build-logsnix build .#tui-stories --print-build-logsgit diff --checkNote:
nix flake check --no-build --print-build-logscurrently fails while evaluatingpackages.x86_64-linux.notion-cli-pnpm-depswithpath ... packages--overeng-notion-cli-package.json is not valid; this is outside the Bun/tui-stories path.tui-stories,bun, and the overlay all evaluate/build.Earlier note:
dt test:tui-stories --no-tuicould not start from this shell becausedtwas not on PATH anddevenv shellhung duringConfiguring shell; the direct Nix package build passed and includes the CLI smoke test.Posted on behalf of @schickling
agent_nameagent_session_idagent_toolagent_tool_versionagent_runtimeagent_modelworktreemachinetooling_profile