-
Notifications
You must be signed in to change notification settings - Fork 33
More options for positioning/anchor, opacity, name max length #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@francislavoie is attempting to deploy a commit to the Hacksore's Team Team on Vercel. A member of the Team first needs to authorize it. |
Ensures the settings window starts minimized and unminimizes when opened. Modifies the pin toggle to target the main overlay window consistently. Broadcasts pin changes to all webviews for consistent state. Persists main window size and position on resize/move events. Adds a pin toggle to the settings page.
c8e3a08 to
7e8c3f1
Compare
|
Very nice! i think i found some instability where overlayed will just crash but don't yet have a repro. The settings windows minimized is a bit odd for me on macOS, i rarely minimize things. Will look over the code and see if there are any callouts but appreciate the work here. if i ever want to do another release i'll need to kick the dust off of #253 so we can have code signing 😂. |
| }); | ||
| // Start the settings window minimized so it's available but not intrusive | ||
| // The `show` call from the UI will restore/unminimize it. | ||
| settings.minimize().ok(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the only thing i really don't like. I believe we should just hide it instead of minimize.
Perhaps the best way to solve "how do i unpin" is a FTUE (first time user experience)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I thought about that too, but this seemed like the simpler option to me. I also looked at global hotkeys but I have concerns about them conflicting with other apps, so onboarding users to set up a hotkey they like for it would be necessary and that's annoying.
Probably best to go with the FTUE, yeah.
Followup on #240, closes #67 (anchoring)
...if too long. This makes sure the overlay will be limited on width, better to plan consistent layouts if using this with OBS for streaming. I realize resizing the window also does this to a certain extent, but I think having both is good for level of control.In a followup commit:
Disclosure: I largely used Github Copilot to write the code changes, but I manually tested and made many minor adjustments by hand afterwards.