Draft
Conversation
Member
|
Just FYI, the Windows build failing is an issue in master which I am fixing in: #1809 |
Collaborator
Author
|
I can wait and rebase it when it is merged |
Member
|
This crashes on startup for me: Maybe one of the changed quantization defaults in Draco requires C++ changes on our side? |
31ab0d2 to
c60ed85
Compare
c60ed85 to
7e7687b
Compare
7e7687b to
14dbeac
Compare
14dbeac to
3530fec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this helps with nixos support