Skip to content

replace polyvox with simpler implementation#2026

Open
RTUnreal wants to merge 6 commits intooverte-org:masterfrom
RTUnreal:remove_polyvox
Open

replace polyvox with simpler implementation#2026
RTUnreal wants to merge 6 commits intooverte-org:masterfrom
RTUnreal:remove_polyvox

Conversation

@RTUnreal
Copy link
Collaborator

@RTUnreal RTUnreal commented Jan 14, 2026

This replaces the functionality of the polyvox library, so we don't have to ship it anymore. :)

This will to introduce a bit of a breaking change, where if borders are filled in, then the faces at the border is not rendered. But considering, that polyvox already did it at some of the sides, I tought it would be better to always not render faces there, so that tiling can be done in the future. This can be changed back if needed

@RTUnreal RTUnreal added needs CR This pull request needs to be code reviewed needs QA This pull request needs to be tested labels Jan 21, 2026
Copy link
Member

@ksuprynowicz ksuprynowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Everything looks good :)
I only have minor feedback about some of the formatting changes, let me know what you think about it.

@RTUnreal RTUnreal requested a review from ksuprynowicz January 25, 2026 11:11
Copy link
Member

@ksuprynowicz ksuprynowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Everything looks good :)

@ksuprynowicz ksuprynowicz added CR approved This pull request has been successfully code reviewed and removed needs CR This pull request needs to be code reviewed labels Feb 13, 2026
@ksuprynowicz
Copy link
Member

I'm getting an assert in Overte_hub:

[02/20 16:13:01] [FATAL] [default] ASSERT: "isInside(index)" in file /home/ksuprynowicz/overte/overte_opt/overte/libraries/entities-renderer/src/RenderablePolyVoxEntityItem.cpp, line 192

@ksuprynowicz
Copy link
Member

Backtrace:

__pthread_kill_implementation 0x00007fffec29e95c
__pthread_kill_internal 0x00007fffec29e9ff
__GI_raise 0x00007fffec249cc2
__GI_abort 0x00007fffec2324ac
QMessageLogger::fatal(char const*, ...) const 0x00007ffff6a92514
qt_assert(const char *, const char *, int) 0x00007ffff6a915ae
VoxelVolume::getVoxelAt RenderablePolyVoxEntityItem.cpp:192
operator() RenderablePolyVoxEntityItem.cpp:614
loop3<…>(const glm::vec<…> &, const glm::vec<…> &, struct {...}) RenderablePolyVoxEntityItem.cpp:153
CubicSurfaceExtractorWithNormals::createMesh RenderablePolyVoxEntityItem.cpp:603
operator() RenderablePolyVoxEntityItem.cpp:1933
ReadWriteLockable::withReadLock<…>(struct {...} &&) const ReadWriteLockable.h:109
operator() RenderablePolyVoxEntityItem.cpp:1918
QtConcurrent::StoredFunctorCall0::runFunctor(void) qtconcurrentstoredfunctioncall.h:70
QtConcurrent::RunFunctionTask::run qtconcurrentrunbase.h:142
<unknown> 0x00007ffff6ae5e21
<unknown> 0x00007ffff6ae28fd
start_thread 0x00007fffec29cb7b
__GI___clone3 0x00007fffec31a7b8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CR approved This pull request has been successfully code reviewed needs QA This pull request needs to be tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants