nix: add a vulkan option and enable xcb QT platform by default#2060
nix: add a vulkan option and enable xcb QT platform by default#2060marius851000 wants to merge 1 commit intooverte-org:masterfrom
Conversation
|
Oh! And I tried adding GLES, but it needed recompilation of glad, and it didn’t appeared important enought to try to fix that. |
|
I would wait for 74 to finish the vulkan implementation, before making it more widely available via the flake. |
RTUnreal
left a comment
RTUnreal
left a comment
There was a problem hiding this comment.
Thank you for the changes, but I would wait on the completed vulkan work, before merging this
| ]; | ||
| ] ++ (lib.optionals (renderingBackend == "Vulkan") [ | ||
| vulkan-loader | ||
| vulkan-headers |
There was a problem hiding this comment.
should that not be in the nativeBuildInputs?
| gif_creator | ||
| artery-font-format | ||
| openssl | ||
| libGL |
There was a problem hiding this comment.
I would also recommend, making this optional if the renderingBackend is not "OpenGL"
|
|
||
| stdenv.mkDerivation { | ||
| pname = "overte"; | ||
| pname = "overte-${lib.toLower renderingBackend}"; |
There was a problem hiding this comment.
maybe leave the opengl rendering to overte and make vulkan overte-vulkan
|
just to mention we also have a grant task to make the different backends switchable via command line arguments, so we wouldn’t need separate versions. but we’ll see if I can actually get that working 😅 |
3 participants
Those changes make add a "overte-full-vulkan" package, that is overte-full but with Vulkan. It also set the default QT platform to xcb. Runnable with
NIXPKGS_ALLOW_INSECURE=1 nix build .#overte-full-vulkan --impure(insecure and impure needed due to the outdated vulnerable qtwebengine, that #2012 fixes)I figured that #2012 also sets the default QT platform to xcb. This will create a merge conflict (which should likely be easily fixed once one or the other PR is merged). I’ll go review this other PR.
Ping @RTUnreal things you might want to take a look at that.