Merged
Conversation
…uard v8 allows us to enter an Isolate::scope multiple times in the same thread, so I widened it to our ScopeGuard as well.
ada-tv
approved these changes
Feb 18, 2026
Collaborator
ada-tv
left a comment
ada-tv
left a comment
There was a problem hiding this comment.
looks ok, assignment client isn't crashing with entity server scripts or the example agent script
the assignment client log is full of QObject::moveToThread: Current thread is not the object's thread and something is starting and killing an agent client repeatedly, but i don't think it's related, it might be the agent client just trying to run an empty script and restarting itself because it thinks it crashed after the empty script has finished
ksuprynowicz
requested changes
Feb 18, 2026
Member
ksuprynowicz
left a comment
ksuprynowicz
left a comment
There was a problem hiding this comment.
Thank you!
There's one place where I think script variable may be destroyed after the script guard.
Other that this all looks good :)
ksuprynowicz
approved these changes
Feb 21, 2026
ksuprynowicz
added
CR approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a crash in assignment-client and changes the register API to force having a ScopeGuard.
Fixes: #2067