Skip to content

[PWCI] "[ovs-dev] MAINTAINERS: Move Russell to emeritus status."#10

Open
ovsrobot wants to merge 1 commit intomainfrom
series_472723
Open

[PWCI] "[ovs-dev] MAINTAINERS: Move Russell to emeritus status."#10
ovsrobot wants to merge 1 commit intomainfrom
series_472723

Conversation

@ovsrobot
Copy link
Owner

@ovsrobot ovsrobot commented Sep 8, 2025

NOTE: This is an auto submission for "[ovs-dev] MAINTAINERS: Move Russell to emeritus status.".

See "http://patchwork.ozlabs.org/project/openvswitch/list/?series=472723" for details.

Summary by Sourcery

Documentation:

  • Move Russell’s entry to the emeritus section in the MAINTAINERS file

Summary by CodeRabbit

  • Documentation
    • Updated maintainers list to reflect team changes: moved Russell Bryant from Active Committers to Emeritus Committers.
    • No functional or user-facing changes.

Moving Russell to emeritus status at his request.

Thanks, Russell, for all your contributions and support!

Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Acked-by: Eelco Chaudron <echaudro@redhat.com>
Signed-off-by: 0-day Robot <robot@bytheb.org>
@sourcery-ai
Copy link

sourcery-ai bot commented Sep 8, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This patch updates MAINTAINERS.rst to reflect Russell’s transition to emeritus status by removing him from the active maintainers list and adding him to the emeritus section.

File-Level Changes

Change Details Files
Move Russell to emeritus status in MAINTAINERS.rst
  • Remove Russell from the active maintainers list
  • Add Russell’s entry under the emeritus maintainers section
MAINTAINERS.rst

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai
Copy link

coderabbitai bot commented Sep 8, 2025

Walkthrough

Updated MAINTAINERS.rst to move Russell Bryant from Active Committers to Emeritus Committers; no other entries changed.

Changes

Cohort / File(s) Summary
Maintainers roster update
MAINTAINERS.rst
Moved Russell Bryant from Active Committers to Emeritus Committers; email retained; no other modifications.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A bunny with a ledger neat,
Hops through names with careful feet.
One moves to Emeritus glade,
In shaded rows, respect displayed.
Ears perked high, stamps applied—
Carrots counted, changes tied.
Thump! The roster’s clarified.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9a2169a and 6437e7a.

📒 Files selected for processing (1)
  • MAINTAINERS.rst (1 hunks)
🔇 Additional comments (2)
MAINTAINERS.rst (2)

94-95: LGTM: Emeritus entry added; ordering and reST formatting look correct.


94-95: Resolved: Russell Bryant appears only once as Emeritus and not in the Active Maintainers list.
Verified one Emeritus entry in MAINTAINERS.rst and no occurrences under the “OVS Maintainers” section.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch series_472723

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

ovsrobot pushed a commit that referenced this pull request Sep 19, 2025
When vport_add_channel() is called duplicate, the resources for previously
specified sock was not freed. This patch fixes this issue.

Reported by Address Sanitizer.

Direct leak of 60 byte(s) in 3 object(s) allocated from:
    #0 0xffffb3658080 in malloc (/usr/lib64/libasan.so.6+0xa9080)
    #1 0x922630 in xmalloc__ lib/util.c:141
    #2 0x922718 in xmalloc lib/util.c:176
    #3 0x9c67e4 in nl_sock_create lib/netlink-socket.c:147
    #4 0x94cb6c in create_nl_sock lib/dpif-netlink.c:283
    #5 0x950bec in dpif_netlink_port_add__ lib/dpif-netlink.c:978
    #6 0x951a20 in dpif_netlink_port_add_compat lib/dpif-netlink.c:1101
    #7 0x951cd0 in dpif_netlink_port_add lib/dpif-netlink.c:1147
    #8 0x616354 in dpif_port_add lib/dpif.c:602
    #9 0x49f424 in port_add ofproto/ofproto-dpif.c:4144
    #10 0x44d51c in ofproto_port_add ofproto/ofproto.c:2204
    #11 0x416914 in iface_do_create vswitchd/bridge.c:2203
    #12 0x416dbc in iface_create vswitchd/bridge.c:2246
    #13 0x40e1d0 in bridge_add_ports__ vswitchd/bridge.c:1225
    #14 0x40e290 in bridge_add_ports vswitchd/bridge.c:1241
    #15 0x40cc6c in bridge_reconfigure vswitchd/bridge.c:952
    #16 0x420884 in bridge_run vswitchd/bridge.c:3440
    #17 0x42f3d0 in main vswitchd/ovs-vswitchd.c:137

Fixes: 69c5158 ("dpif-netlink: don't allocate per thread netlink sockets")
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
Signed-off-by: 0-day Robot <robot@bytheb.org>
ovsrobot pushed a commit that referenced this pull request Oct 9, 2025
When vport_add_channel() is called duplicate, the resources for previously
specified sock was not freed. This patch fixes this issue.

Reported by Address Sanitizer.

Direct leak of 60 byte(s) in 3 object(s) allocated from:
    #0 0xffffb3658080 in malloc (/usr/lib64/libasan.so.6+0xa9080)
    #1 0x922630 in xmalloc__ lib/util.c:141
    #2 0x922718 in xmalloc lib/util.c:176
    #3 0x9c67e4 in nl_sock_create lib/netlink-socket.c:147
    #4 0x94cb6c in create_nl_sock lib/dpif-netlink.c:283
    #5 0x950bec in dpif_netlink_port_add__ lib/dpif-netlink.c:978
    #6 0x951a20 in dpif_netlink_port_add_compat lib/dpif-netlink.c:1101
    #7 0x951cd0 in dpif_netlink_port_add lib/dpif-netlink.c:1147
    #8 0x616354 in dpif_port_add lib/dpif.c:602
    #9 0x49f424 in port_add ofproto/ofproto-dpif.c:4144
    #10 0x44d51c in ofproto_port_add ofproto/ofproto.c:2204
    #11 0x416914 in iface_do_create vswitchd/bridge.c:2203
    #12 0x416dbc in iface_create vswitchd/bridge.c:2246
    #13 0x40e1d0 in bridge_add_ports__ vswitchd/bridge.c:1225
    #14 0x40e290 in bridge_add_ports vswitchd/bridge.c:1241
    #15 0x40cc6c in bridge_reconfigure vswitchd/bridge.c:952
    #16 0x420884 in bridge_run vswitchd/bridge.c:3440
    #17 0x42f3d0 in main vswitchd/ovs-vswitchd.c:137

Reproduce steps:
    ovs-vsctl add-br br-ovs
    ovs-vsctl add-port br-ovs test -- set interface test type=internal
    ip netns add ns_test
    ip link set test netns ns_test
    ip netns del ns_test
    ifconfig br-ovs up
    sleep 1
    ifconfig br-ovs down
    sleep 1
    ovs-vsctl del-br br-ovs

Fixes: 69c5158 ("dpif-netlink: don't allocate per thread netlink sockets")
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
Signed-off-by: 0-day Robot <robot@bytheb.org>
ovsrobot pushed a commit that referenced this pull request Oct 27, 2025
Introduce an optional parameter to `ovs-appctl ovs/route/show` for
printing non-default routing tables:

  ovs-appctl ovs/route/show [table=all|id]

Default usage is unchanged:

  ovs-appctl ovs/route/show
  Route Table:
  Cached: ::1/128 dev lo SRC ::1
  Cached: 127.0.0.0/8 dev lo SRC 127.0.0.1 local
  Cached: 10.7.7.0/24 dev br-phy1 SRC 10.7.7.17
  Cached: 0.0.0.0/0 dev eth1 GW 10.0.0.1 SRC 10.0.0.2

New usage with a specific table displays only the routes from that
table:

  ovs-appctl ovs/route/show table=10
  Route Table #10:
  Cached: 10.7.7.0/24 dev br-phy0 SRC 10.7.7.7

Special table 'all' displays all of the routes, the ones which are
coming from a non-default table have additional field 'table' displayed:

  ovs-appctl ovs/route/show table=all
  Cached: 10.7.7.0/24 dev br-phy1 SRC 10.7.7.17 table 20
  Cached: 10.7.7.0/24 dev br-phy0 SRC 10.7.7.7 table 10
  Cached: ::1/128 dev lo SRC ::1
  Cached: 127.0.0.0/8 dev lo SRC 127.0.0.1 local
  Cached: 10.7.7.0/24 dev br-phy1 SRC 10.7.7.17
  Cached: 0.0.0.0/0 dev eth1 GW 10.0.0.1 SRC 10.0.0.2

Signed-off-by: Dima Chumak <dchumak@nvidia.com>
Signed-off-by: 0-day Robot <robot@bytheb.org>
ovsrobot pushed a commit that referenced this pull request Jan 9, 2026
Introduce an optional parameter to `ovs-appctl ovs/route/show` for
printing non-default routing tables:

  ovs-appctl ovs/route/show [table=all|id]

Default usage is unchanged:

  ovs-appctl ovs/route/show
  Route Table:
  Cached: ::1/128 dev lo SRC ::1
  Cached: 127.0.0.0/8 dev lo SRC 127.0.0.1 local
  Cached: 10.7.7.0/24 dev br-phy1 SRC 10.7.7.17
  Cached: 0.0.0.0/0 dev eth1 GW 10.0.0.1 SRC 10.0.0.2

New usage with a specific table displays only the routes from that
table:

  ovs-appctl ovs/route/show table=10
  Route Table #10:
  Cached: 10.7.7.0/24 dev br-phy0 SRC 10.7.7.7

Special table 'all' displays all of the routes, the ones which are
coming from a non-default table have additional field 'table' displayed:

  ovs-appctl ovs/route/show table=all
  Cached: 10.7.7.0/24 dev br-phy1 SRC 10.7.7.17 table 20
  Cached: 10.7.7.0/24 dev br-phy0 SRC 10.7.7.7 table 10
  Cached: ::1/128 dev lo SRC ::1
  Cached: 127.0.0.0/8 dev lo SRC 127.0.0.1 local
  Cached: 10.7.7.0/24 dev br-phy1 SRC 10.7.7.17
  Cached: 0.0.0.0/0 dev eth1 GW 10.0.0.1 SRC 10.0.0.2

Signed-off-by: Dima Chumak <dchumak@nvidia.com>
Signed-off-by: 0-day Robot <robot@bytheb.org>
ovsrobot pushed a commit that referenced this pull request Jan 15, 2026
Introduce an optional parameter to `ovs-appctl ovs/route/show` for
printing non-default routing tables:

  ovs-appctl ovs/route/show [table=all|id]

Default usage is unchanged:

  ovs-appctl ovs/route/show
  Route Table:
  Cached: ::1/128 dev lo SRC ::1
  Cached: 127.0.0.0/8 dev lo SRC 127.0.0.1 local
  Cached: 10.7.7.0/24 dev br-phy1 SRC 10.7.7.17
  Cached: 0.0.0.0/0 dev eth1 GW 10.0.0.1 SRC 10.0.0.2

New usage with a specific table displays only the routes from that
table:

  ovs-appctl ovs/route/show table=10
  Route Table #10:
  Cached: 10.7.7.0/24 dev br-phy0 SRC 10.7.7.7

Special table 'all' displays all of the routes, the ones which are
coming from a non-default table have additional field 'table' displayed:

  ovs-appctl ovs/route/show table=all
  Cached: 10.7.7.0/24 dev br-phy1 SRC 10.7.7.17 table 20
  Cached: 10.7.7.0/24 dev br-phy0 SRC 10.7.7.7 table 10
  Cached: ::1/128 dev lo SRC ::1
  Cached: 127.0.0.0/8 dev lo SRC 127.0.0.1 local
  Cached: 10.7.7.0/24 dev br-phy1 SRC 10.7.7.17
  Cached: 0.0.0.0/0 dev eth1 GW 10.0.0.1 SRC 10.0.0.2

Signed-off-by: Dima Chumak <dchumak@nvidia.com>
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants