Reverse logic of checking output in @inspectFile #1715
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes @inspectFile in ModSecurity 3.x to operate in exact the same way as it operates in ModSecurity 2.x, so existing helper scripts like runav.pl [1] will work without any changes. [1] https://github.com/SpiderLabs/owasp-modsecurity-crs/blob/v3.0/master/util/av-scanning/runav.pl
Contributor
|
Merged! thanks. 9505ca7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes
@inspectFilein ModSecurity 3.x to operate in exact the same way as it operates in ModSecurity 2.x, so existing helper scripts likerunav.pl[1] will work without any changes.See the difference in the corresponding logic of existing code:
ModSecurity 2.x: https://github.com/SpiderLabs/ModSecurity/blob/v2/master/apache2/re_operators.c#L4069-L4074
libmodsecurity (ModSecurity 3.x): https://github.com/SpiderLabs/ModSecurity/blob/v3/master/src/operators/inspect_file.cc#L76-L78
(I would say that it could be better rather to check exit code than output, but for the sake of compatibility of existing setups the proposed solution will also work.)
[1] https://github.com/SpiderLabs/owasp-modsecurity-crs/blob/v3.0/master/util/av-scanning/runav.pl