This repository was archived by the owner on Nov 8, 2018. It is now read-only.
Cloud neutral app #1605
Merged
Cloud neutral app #1605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChristophWurst, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @Mar1u5 and @jancborchardt to be potential reviewers |
Contributor
|
Shouldnt we also change the README.md to call it "Mail" instead of "ownCloud Mail" ❓ |
Contributor
Author
Yes, of course. Pushed another commit |
bower.json
Outdated
| "name": "mail", | ||
| "version": "0.5.3", | ||
| "description": "ownCloud Mail App", | ||
| "description": "Mail App", |
Contributor
There was a problem hiding this comment.
»Mail app«, app should be lowercase. ;)
Contributor
|
If you fix the lowercase stuff I commented you get a thumbs up ;) |
ChristophWurst
force-pushed
the
cloud-neutral-app
branch
from
53f5b82 to
307159c
Compare
Contributor
Author
|
comments fixed and conflicts resolved, please have another look @jancborchardt |
Contributor
|
👍 |
Contributor
|
Thanks! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This app works for ownCloud and Nextcloud, so let's remove the specific branding and make it a neutral app. This follows @oparoz'es PR on Gallery, see owncloud/gallery#696.
@DeepDiver1975 @owncloud/mail objections?