[WIP] Enable encryption in tests #317
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ah cool, thanks. I've noticed recently that core finally has traits for the things we regularly use :) |
|
@oparoz what's the state of it? Would be nice to have for 8.2.1. Are you still working on it? Do you need any help? |
Contributor
Author
|
I don't see this as a high priority, but something which would be nice to have in order to cover more use-cases, so I haven't looked at it since creating the PR. Just like with some acceptance tests, I was thinking of keeping a special branch open which runs the encrypted tests. That way it doesn't take an hour to run tests. The main problem with that approach is that PRs wouldn't be automatically checked... Any thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently does not work because there are no (encryption) hooks attached to the login method used in tests: owncloud/core#18085