Sort button hidden if only one image in album

[mbtamuli]

Fixes: #573

Licence: AGPL

Description

Sort buttons were shown irrespective of whether there was one or more images. If there is only one image, sort buttons need not be shown

Features

• Sort buttons are now shown only when there are more than one

Screenshots or screencasts

Tested on

• [*] Ubuntu 15.10/Chrome
• [*] Ubuntu 15.10/Firefox

Reviewers

@oparoz This commit solves issue #573

[mention-bot]

By analyzing the blame information on this pull request, we identified @oparoz to be a potential reviewer

[tahaalibra]

👍 Working good..
tested using

• Logged In
• Public

NOTE: this is working only on images and not folder

[oparoz]

@mbtamuli - Thanks for the PR, but please be careful. The task was already assigned to somebody else and it's best to ask that person's permission before taking over.

As discussed in #573, it should also work for folders. The approach is similar, but you have to find a way to count folders.

[mbtamuli]

@oparoz Okay. Sorry. Will keep this in mind next time. Can you please mention other junior jobs I can work on? Preferably PHP based, although JS based tasks will also be fine.

[oparoz]

@mbtamuli https://github.com/owncloud/gallery/issues?q=is%3Aissue+is%3Aopen+label%3A%22junior+job%22
Most are JS tasks.

• This is a PR which could be finished, but you'll have to ask the person currently assigned: [WIP] add full size preview if previews are disabled #512
• These are interesting: Only activate uploading if we can write to the current folder #521 and In-app settings buttons and user settings section [$15] #4
• All the issues which require help: https://github.com/owncloud/gallery/issues?q=is%3Aissue+is%3Aopen+label%3A%22coder+wanted%22

Most task involve some JS. The ones which don't have already been selected for the GSoC AFAIK.

This one about the API is pure PHP: #408. The ajax calls have to be modified, but that's step2.

Also, Scrutinizer makes recommendations. Recently something was merged before it was ready and it could be improved: https://scrutinizer-ci.com/g/owncloud/gallery/inspections/3156c45f-e8b9-4852-9e6a-5f0f16a47a77

Missing unit tests could be written, etc.

[oparoz]

Closing in favour of #577 . Feel free to help each other out :)

[oparoz]

I've also added some basic app ideas to the wiki

[mbtamuli]

Are you talking about these ideas 2016 (current)? Are these not for the GSoC event?

[oparoz]

Sorry, I missed this message. I was talking about this:
https://github.com/owncloud/gallery/wiki/GSoC-2016#some-appframework-app-ideas