Create .nomedia file from the album itself #643
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted "Hide Album" function Adapted owncloud/core@d386168 Hide Album function will create a .nomedia file in the current album and refreshs after creating .nomedia file
|
By analyzing the blame information on this pull request, we identified @oparoz, @imjalpreet and @PVince81 to be potential reviewers |
15 tasks
Member
|
@eknoes I have tested this and the main feature of this piece of code is working. On clicking Hide Album, The album gets hidden and the .nomedia file also gets created. But I have a few suggestions:
I will give more suggestions if needed. Cheers! |
Contributor
|
I agree with both suggestions |
Contributor
|
@eknoes Let me know if you have some time in the coming days, otherwise we can merge this as-is and implement the suggestions at a later time. |
Contributor
Author
|
Sorry, the semester started again and so I don't really have the time to do this right now. |
Contributor
|
OK, thank you @eknoes |
Merged
Contributor
|
Transferred locally via #677 and will be part of the next release of Gallery+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Licence: MIT
Adapted owncloud/core@d386168 to make work on #547 easier.
Description
This pull request makes it possible, to create a .nomedia file from the album itself via the [+] button. Furthermore it adapts owncloud/core@d386168, so that there is a standardized way to extend the [+]-menu.
Features
Tests
Test plan
Tested on
TODO
Check list
This is my first pull request, so if you have any advice for me please feel welcome.