Skip to content

Use Share 2.0 #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oparoz merged 4 commits into from
Jun 11, 2016
Merged

Use Share 2.0 #668

oparoz merged 4 commits into from
Jun 11, 2016

Conversation

@oparoz
Copy link
Contributor

@oparoz oparoz commented Jun 11, 2016 •
edited
Loading

Fixes: #579

Licence: AGPL

Description

Original PR #589 by @tahaalibra

Affects OCA\Gallery\Environment\Environment and OCA\Gallery\Middleware\EnvCheckMiddleware

Important changes

  • getShareByToken now returns an IShare Object
  • The server's shareManager (OCP\Share\IManager) is used to get the object using a token

Tested on

  • Ubuntu14.04/Chrome
  • Windows 10/Chrome
  • Windows 10/Firefox

Todo

Reviewers

@oparoz oparoz added this to the 9.1-current milestone Jun 11, 2016
@oparoz oparoz self-assigned this Jun 11, 2016
@oparoz oparoz mentioned this pull request Jun 11, 2016
Closed
4 tasks
@oparoz oparoz force-pushed the tahaalibra-share_20 branch from 97dd786 to 62cff93 Compare June 11, 2016 02:25
@oparoz oparoz merged commit bf69aaf into master Jun 11, 2016
@oparoz oparoz deleted the tahaalibra-share_20 branch June 11, 2016 02:34
@oparoz oparoz mentioned this pull request Jun 11, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@oparoz oparoz

Labels

technical debt

Projects

None yet

Milestone

oC 9.1 / NC 10

Development

Successfully merging this pull request may close these issues.

3 participants

@oparoz @tahaalibra