Fix for string id #689
Merged
Fix for string id #689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 7, 2016
Closed
Contributor
|
Is this really necessary for 9.1+ ? I thought it only was a problem on 9. |
Contributor
Author
|
I don't have an env to reproduce the original issue so better be sure. |
Contributor
|
OK, thanks. I never had any issue on 9.1, but as you said, it doesn't hurt to keep this change in. |
Contributor
Author
|
I'll prepare the backports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gallery part for owncloud/core#23066
@butonic @oparoz
will have a look at the unit tests that were mentionned to fail