Implement working .php_cs.dist #794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note: only the PHP 7.2 CI jobs were failing. The "old" way seems to be working still on PHP 5.6 7.0. and 7.1 |
Contributor
Author
|
@patrickjahns I am just getting CI working again here - not attempting to cleanup the way the whole thing works, or to move it to drone. That is another big job. |
phil-davis
force-pushed
the
php_cs-dist-format
branch
from
3268e36 to
bc71097
Compare
patrickjahns
approved these changes
Aug 28, 2018
Contributor
patrickjahns
left a comment
patrickjahns
left a comment
There was a problem hiding this comment.
🌞 - happy CI - happy QA-Team 🌞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the "old" way of doing
exclude()in.php_cs.disthas stopped working.In CI,
php-cs-fixeris checkingc3.phphttps://travis-ci.org/owncloud/gallery/jobs/421365878
It should be ignoring it.
I have updated the code in
.php_cs.distto match the way it is now done in other app repos.Then it fails on PHP 7.2 with outdated versions of dev dependencies, so
composer updatehas been done.Then
php-cs-fixerreports new code format issues that it now finds. So those have been applied.And finally CI passes again.