ocis_full: reintroduce env interpolation with pinned tag+digest defaults#12066
Draft
Copilot wants to merge 2 commits intoocis_full-renovate-securityfrom
Draft
ocis_full: reintroduce env interpolation with pinned tag+digest defaults#12066Copilot wants to merge 2 commits intoocis_full-renovate-securityfrom
Copilot wants to merge 2 commits intoocis_full-renovate-securityfrom
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
…ose files Co-authored-by: dj4oC <115982880+dj4oC@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on OCIS_FULL deployment example
ocis_full: reintroduce env interpolation with pinned tag+digest defaults
Feb 26, 2026
Contributor
|
There is a working ocis_full deployment setup created by intention. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Image override env vars in
.env(e.g.TRAEFIK_DOCKER_TAG,OCIS_DOCKER_TAG,TIKA_IMAGE,COLLABORA_DOCKER_TAG, etc.) were non-functional after the switch to hard-pinnedimage: name:tag@sha256:...in compose files — editing.envhad no effect on which images were pulled.Description
Reintroduce env interpolation across all affected compose files using
${VAR:-pinned_tag@sha256:digest}syntax. The pinned digest remains the secure default; users can override via.envwhen needed. Renovate continues updating pinned defaults in compose files via the docker-compose manager.Compose file changes — all hardcoded
image:lines replaced with env interpolation:Files updated:
docker-compose.yml,ocis.yml,collabora.yml,onlyoffice.yml,tika.yml,clamav.yml,mailserver.yml,web_extensions/importer.yml.envchanges:ONLYOFFICE_DOCKER_TAGfrom9.2.1.1(digest-less, would bypass pinning) to empty so the compose default appliesRelated Issue
Motivation and Context
The "manual override only" documentation was misleading: users had no way to change the pulled image version via
.envafter the hard-pin migration. This restores the expected behaviour while keeping digest pinning as the secure default path.How Has This Been Tested?
docker compose configresolves images to the pinned tag+digest when env vars are empty, and to the override value when setScreenshots (if appropriate):
Types of changes
Checklist:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.