Skip to content

fix: Integrate gemini valve/config for "Thinking" texts#160

Open
swarnat wants to merge 1 commit intoowndev:mainfrom
swarnat:translation-gemini-thinking-text
Open

fix: Integrate gemini valve/config for "Thinking" texts#160
swarnat wants to merge 1 commit intoowndev:mainfrom
swarnat:translation-gemini-thinking-text

Conversation

@swarnat
Copy link
Copy Markdown

@swarnat swarnat commented Apr 16, 2026

I'm not sure, if such direct Merge Requests would be accepted, but I needed german words as "Thinking" and "Thought".

So I integrated them a config value anbd prepare MR.
That is a small, but helpful, support for user acceptance.

Because I will try to contribute more, please correct, when I'm doing something wrong in process.

@owndev owndev added the status: blocked Blocked, cannot be processed further label Apr 27, 2026
@owndev
Copy link
Copy Markdown
Owner

owndev commented Apr 30, 2026

Hi @swarnat

Thanks for your suggestion.

The problem is that these aren't the only words displayed to the user (see image).
image

Do you think these would also need to be translated? Because if all these texts required their own settings field, it would clutter the settings even more than they already do.


I could just add a settings field, and then users could specify the translations as JSON.

But I'm not sure if I want to implement something like that right now.

If this is really desired, you can create a feature request so I can add it to the backlog.

@swarnat
Copy link
Copy Markdown
Author

swarnat commented Apr 30, 2026

You’re right. I only handled the text-based output and didn’t use the images.

No need for you to do that. 😉
I’ll update the merge request based on your suggestion.

Using a single JSON file is much safer, especially if there will be more texts later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: blocked Blocked, cannot be processed further

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants