Skip to content

Conversation

@kirkpsmith
Copy link
Contributor

Closes #136

@jalinei jalinei self-requested a review October 15, 2025 12:22
@jalinei
Copy link
Contributor

jalinei commented Oct 15, 2025

CI build test failed. I think it is because of the comment after the backslash.
Maybe we can enhance the syntax by adding parenthesis like below ?

mcumgr_executable = (
    "mcumgr"     if platform.system() == 'Linux' and platform.machine() == 'x86_64' else
    "mcumgr-rpi" if platform.system() == 'Linux' and platform.machine() == 'armv7l' else
    "mcumgr-rpi" if platform.system() == 'Linux' and platform.machine() == 'aarch64' else
    "mcumgr-mac" if platform.system() == 'Darwin' else
    "mcumgr.exe" if platform.system() == 'Windows' else
    None
)

@kirkpsmith kirkpsmith marked this pull request as draft October 16, 2025 09:38
@kirkpsmith kirkpsmith marked this pull request as ready for review October 16, 2025 09:42
@jalinei jalinei merged commit cc5fc95 into owntech-foundation:main Oct 16, 2025
1 check passed
@jalinei
Copy link
Contributor

jalinei commented Oct 16, 2025

Just merged @kirkpsmith, thanks for the contribution 😃

@kirkpsmith kirkpsmith deleted the patch-1 branch October 19, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in pre_bootloader_serial.py prevents building Core example for rpi5, easy fix

2 participants