feat(parser): add ON trigger and TRIGGER PROCEDURE statement parsing#31
Merged
LostRhapsody merged 1 commit intomasterfrom Apr 10, 2026
Merged
feat(parser): add ON trigger and TRIGGER PROCEDURE statement parsing#31LostRhapsody merged 1 commit intomasterfrom
LostRhapsody merged 1 commit intomasterfrom
Conversation
Add full parsing support for ABL's ON statement (all 3 forms) and the TRIGGER PROCEDURE statement, completing the last major parser gap. ON statement forms: - UI/developer event triggers with comma-separated events/widgets, OR clause chaining, ANYWHERE, IN FRAME/IN BROWSE qualifiers, and trigger actions (DO block, single statement, REVERT, PERSISTENT RUN) - Database event triggers (CREATE/DELETE/FIND/WRITE/ASSIGN) with NEW/OLD BUFFER referencing, OLD VALUE, and OVERRIDE - Key remapping (ON key-label key-function) TRIGGER PROCEDURE for schema triggers: - All 5 standard events plus REPLICATION-CREATE/DELETE/WRITE - WRITE with optional NEW/OLD BUFFER clauses - ASSIGN with both OF table.field and NEW VALUE variable forms New AST types: OnKind, OnAction, OnEventClause, DbTriggerEvent, TriggerReferencing, WidgetRef, WidgetQualifier, TriggerAssignParam. 29 new tests (406 total parser tests), all passing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Merging this PR will improve performance by 11.13%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | expressions |
304.5 µs | 274 µs | +11.13% |
Comparing feat/on-triggers (6dfffdc) with master (4eb3af4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What's Implemented
ON UI/Developer Event Triggers:
ON CHOOSE OF btn1 OR ENTRY OF fill1)ANYWHERE(standalone and after widget list)IN FRAME/IN BROWSEwidget qualifiersON Database Event Triggers:
table.fieldnames for ASSIGN OF targetsON Key Remapping:
ON F1 HELP.TRIGGER PROCEDURE:
New AST Types
OnKind,OnAction,OnEventClause,DbTriggerEvent,TriggerReferencing,WidgetRef,WidgetQualifier,TriggerAssignParamTest Plan
cargo clippy -D warningspassescargo fmt --checkpassesPost-Deploy Monitoring & Validation
No additional operational monitoring required: this is a parser library with no runtime deployment.