Open
Conversation
sub-commits:
feat: implement a whitelist to the config
feat: add a whitelist to the stream server
chore: update how we get yaml ip into cpp
chore: add debug for whitelist contents
chore: add log whitelist function to try format
chore: remove c str
chore: manually split for generated code
chore: use ESP_LOGCONFIG for logging ip
chore: add print to init
chore: add esphome namespace back to ip calls
chore: call str on ip
chore: add dummy ip to check on log
chore: use ipaddress in init
doc: update readme with newer whitelist set up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily introduces a new feature to the
stream_servercomponent, which adds support for an IP address whitelist. This enhancement allows users to specify which IP addresses are permitted to connect to the stream server, providing an additional layer of security.Let me know if you would like this to be included and I can update the docs to be a bit more unified. All good if you'd rather close the PR though.
Key changes include:
Documentation Updates:
README.mdto reflect the new whitelist feature and provide configuration examples. [1] [2]Feature Implementation:
CONF_WHITELISTto thestream_servercomponent incomponents/stream_server/__init__.py. [1] [2]to_codefunction to handle the new whitelist configuration.Code Enhancements:
components/stream_server/stream_server.cpp:accept,flush, andwritemethods to enforce the whitelist. [1] [2] [3]Header File Updates:
components/stream_server/stream_server.hto declare the new whitelist-related methods and member variables. [1] [2]sub-commits: