Skip to content

Bitcoincommiter#29

Open
oxf71 wants to merge 13 commits intomainfrom
bitcoincommiter
Open

Bitcoincommiter#29
oxf71 wants to merge 13 commits intomainfrom
bitcoincommiter

Conversation

@oxf71
Copy link
Owner

@oxf71 oxf71 commented Nov 14, 2023

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #29 (466888d) into main (1087db7) will decrease coverage by 0.48%.
The diff coverage is 31.42%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   68.40%   67.93%   -0.48%     
==========================================
  Files         128      139      +11     
  Lines       10822    10962     +140     
==========================================
+ Hits         7403     7447      +44     
- Misses       2996     3091      +95     
- Partials      423      424       +1     
Files Coverage Δ
x/bitcoincommiter/genesis.go 100.00% <100.00%> (ø)
x/bitcoincommiter/keeper/params.go 100.00% <100.00%> (ø)
x/bitcoincommiter/types/genesis.go 100.00% <100.00%> (ø)
x/bitcoincommiter/keeper/keeper.go 84.61% <84.61%> (ø)
x/bitcoincommiter/keeper/msg_server.go 0.00% <0.00%> (ø)
x/bitcoincommiter/types/keys.go 0.00% <0.00%> (ø)
x/bitcoincommiter/keeper/query_params.go 57.14% <57.14%> (ø)
x/bitcoincommiter/types/codec.go 0.00% <0.00%> (ø)
x/bitcoincommiter/types/params.go 40.00% <40.00%> (ø)
x/bitcoincommiter/module_simulation.go 0.00% <0.00%> (ø)
... and 1 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant