Skip to content

run ui-test and ui-lint targets in CI #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iliana merged 1 commit into from
Jul 17, 2025
Merged

run ui-test and ui-lint targets in CI #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .github/buildomat/jobs/ui-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
#!/bin/bash
#:
#: name = "ui-test"
#: variety = "basic"
#: target = "ubuntu-22.04"

set -o errexit
set -o pipefail
set -o xtrace

source .github/buildomat/linux-setup.sh
install_output=$(npx @puppeteer/browsers install chrome@stable)
echo "${install_output}"
CHROME_BIN=$(awk '{ print $2 }' <<<"${install_output}")
export CHROME_BIN

sudo apt-get satisfy -y --no-install-recommends \
"$(tr '\n' , <"$(dirname "${CHROME_BIN}")"/deb.deps)"

gmake -j"$(nproc)" ui-test || error=$?
gmake -j"$(nproc)" ui-lint
exit "${error:-0}"
2 changes: 1 addition & 1 deletion pkg/ui/workspaces/db-console/karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"use strict";

const webpackConfig = require("./webpack.app")(
{ dist: "ccl" },
{ dist: "oss" },
{ mode: "development" },
);

Expand Down
27 changes: 0 additions & 27 deletions pkg/ui/workspaces/db-console/src/app.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ import { App } from "src/app";
import { AdminUIState, createAdminUIStore } from "src/redux/state";

import ClusterOverview from "src/views/cluster/containers/clusterOverview";
import NodeList from "src/views/clusterviz/containers/map/nodeList";
import { ClusterVisualization } from "src/views/clusterviz/containers/map";
import { NodeGraphs } from "src/views/cluster/containers/nodeGraphs";
import { NodeOverview } from "src/views/cluster/containers/nodeOverview";
import { Logs } from "src/views/cluster/containers/nodeLogs";
Expand Down Expand Up @@ -98,26 +96,6 @@ describe("Routing to", () => {
});
});

describe("'/overview/list' path", () => {
it("routes to <NodeList> component", () => {
navigateToPath("/overview");
const clusterOverview = appWrapper.find(ClusterOverview);
assert.lengthOf(clusterOverview, 1);
const nodeList = clusterOverview.find(NodeList);
assert.lengthOf(nodeList, 1);
});
});

describe("'/overview/map' path", () => {
it("routes to <ClusterViz> component", () => {
navigateToPath("/overview/map");
const clusterOverview = appWrapper.find(ClusterOverview);
const clusterViz = appWrapper.find(ClusterVisualization);
assert.lengthOf(clusterOverview, 1);
assert.lengthOf(clusterViz, 1);
});
});

{
/* time series metrics */
}
Expand Down Expand Up @@ -192,11 +170,6 @@ describe("Routing to", () => {
/* node details */
}
describe("'/node' path", () => {
it("routes to <NodeList> component", () => {
navigateToPath("/node");
assert.lengthOf(appWrapper.find(NodeList), 1);
});

it("redirected to '/overview/list'", () => {
navigateToPath("/node");
const location = history.location;
Expand Down
2 changes: 0 additions & 2 deletions pkg/ui/workspaces/db-console/src/components/tooltip/tooltip.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import { storiesOf } from "@storybook/react";

import * as ClusterTooltips from "src/views/cluster/containers/clusterOverview/tooltips";
import * as NodeOverviewTooltips from "src/views/cluster/containers/nodeOverview/tooltips";
import * as CapacityArkTooltips from "src/views/clusterviz/components/nodeOrLocality/tooltips";
import * as GraphTooltips from "src/views/cluster/containers/nodeGraphs/dashboards/graphTooltips";
import { ToolTipWrapper } from "src/views/shared/components/toolTip";
import {
Expand Down Expand Up @@ -101,7 +100,6 @@ storiesOf("Tooltips/Cluster Overview Page", module)
.addDecorator(styledWrapper(wrapperStyle))
.add("Summary tooltips", () => tooltipsStack(ClusterTooltips))
.add("Node overview tooltips", () => tooltipsStack(NodeOverviewTooltips))
.add("Node map tooltips", () => tooltipsStack(CapacityArkTooltips))
.add("Node List tooltips", () => (
<>
{tooltipsStack(plainNodeTooltips)}
Expand Down
6 changes: 6 additions & 0 deletions pkg/ui/workspaces/db-console/src/views/reports/containers/stores/encryption.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ export interface EncryptionStatusProps {
}

export default class EncryptionStatus {
props: EncryptionStatusProps;

constructor(props: EncryptionStatusProps) {
this.props = props;
}

getEncryptionRows(): React.ReactElement<any> {
return null;
}
Expand Down
2 changes: 0 additions & 2 deletions pkg/ui/workspaces/db-console/tests-loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,5 @@
// licenses/APL.txt.

const testsContext = require.context("./src", true, /\.spec\.(ts|tsx)$/);
const cclTestsContext = require.context("./ccl/src", true, /\.spec\.(ts|tsx)$/);

testsContext.keys().forEach(testsContext);
cclTestsContext.keys().forEach(cclTestsContext);