Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace github.com/cockroachdb/pebble => github.com/oxidecomputer/pebbleThis is in service of being able to backport a change. As part of doing this, we're also running the Pebble tests in CI, for which we have harmonized the go.mod files between this repo and the Pebble repo.
zstdis downgraded from v1.5.0 to v1.4.5 to keep the versions consistent. Updating zstd to 1.5.x requires modifying test data in Pebble that I'm not entirely qualified to fix, and CockroachDB at this version does not use zstd compression at all (it was not introduced upstream until 24.1).Full changes: oxidecomputer/pebble@d1171c6...1c81133