improve logging around unhealthy clocks#60
Merged
iliana merged 1 commit intorelease-22.1-oxidefrom Mar 16, 2026
Merged
Conversation
We have seen this error
clock synchronization error: this node is more than 500ms away from at least half of the known nodes
but when this happens it's not clear what the real issue is. Are the
clocks 501ms away? or 5000ms?
This logs an additional error any time a remote node is unhealthy
E260312 20:20:10.978114 15 2@rpc/clock_offset.go:256 [-] 3 node 3 is not healthy: clock offset is off=91ns, err=31ns, at=1970-01-01 00:00:00 +0000 UTC
JustinAzoff
force-pushed
the
justin/log-unhealthy-clocks
branch
from
42ad73b to
3ca158b
Compare
iliana
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Mar 20, 2026
Primarily for debugging (#9427, and time sync problems). The vast majority of changes here are build system related or updating dependencies that are used in tests only, but there are some actual code changes worth pointing out: - oxidecomputer/cockroach#46 (r+ @sudomateo) - oxidecomputer/pebble@e7c3451 "fix lints; run tests in buildomat" (not reviewed) - oxidecomputer/pebble@06125d2 backport of "sstable: do a bit flip computation on a checksum mismatch in the Reader" (not reviewed) - oxidecomputer/cockroach#60 (@JustinAzoff; r+ @iliana) - oxidecomputer/cockroach#64 (not reviewed) - oxidecomputer/cockroach#65 (r+ @sudomateo) Full delta: oxidecomputer/cockroach@367bca4...86fdbfc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have seen this error
but when this happens it's not clear what the real issue is. Are the clocks 501ms away? or 5000ms?
This logs an additional error any time a remote node is unhealthy