Merged
Conversation
iliana
commented
Mar 13, 2026
| require.Eventually(t, func() bool { | ||
| return nd.ConnHealthTryDial(staticNodeID, rpc.DefaultClass) == nil | ||
| }, time.Second, 10*time.Millisecond) | ||
| }, 5*time.Second, 10*time.Millisecond) |
Collaborator
Author
There was a problem hiding this comment.
Closing the connection pops the breaker. The lines just above this allow 5 seconds for a popped breaker to recover. So why not here?
| // Set up an empty 9-node cluster with simulated latencies. | ||
| demoCtx.SimulateLatency = true | ||
| demoCtx.NumNodes = 9 | ||
| demoCtx.Localities = defaultLocalities |
Collaborator
Author
There was a problem hiding this comment.
Not really sure why this fixes things and it kind of pisses me off. Best I can tell this ends up being nil if it's not set, so maybe this test never worked properly and any simulated latencies were an accident?
Comment on lines
-1367
to
-1373
| if tc.expectNonTrivialSchemaChangeTime && postCommitJobsInterval.AsFloat64() < 0.1 { | ||
| t.Fatalf( | ||
| "expected schema changes to take longer than 0.1 seconds, took: %v", | ||
| postCommitJobsInterval.AsFloat64(), | ||
| ) | ||
| } | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Failing the test because it took less than 100ms to insert and alter 10,000 rows is ridiculous. I think the expectNonTrivialSchemaChangeTime is really meant to make sure that the other queries don't take too long, not to make sure that this query takes long enough...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.