Skip to content

remove analytics and update checks from pkg/ui #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iliana merged 1 commit into from
Mar 17, 2026
Merged

remove analytics and update checks from pkg/ui #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 1 addition & 23 deletions pkg/ui/workspaces/cluster-ui/src/sessions/sessionDetailsConnected.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

import { connect } from "react-redux";
import { RouteComponentProps, withRouter } from "react-router-dom";
import { analyticsActions, AppState } from "src/store";
import { AppState } from "src/store";
import { SessionDetails } from ".";
import {
actions as sessionsActions,
Expand Down Expand Up @@ -39,28 +39,6 @@ export const SessionDetailsPageConnected = withRouter(
cancelQuery: terminateQueryActions.terminateQuery,
refreshNodes: nodesActions.refresh,
refreshNodesLiveness: nodesLivenessActions.refresh,
onTerminateSessionClick: () =>
analyticsActions.track({
name: "Session Actions Clicked",
page: "Sessions Details",
action: "Cancel Session",
}),
onTerminateStatementClick: () =>
analyticsActions.track({
name: "Session Actions Clicked",
page: "Sessions Details",
action: "Cancel Statement",
}),
onBackButtonClick: () =>
analyticsActions.track({
name: "Back Clicked",
page: "Sessions Details",
}),
onStatementClick: () =>
analyticsActions.track({
name: "Statement Clicked",
page: "Sessions Details",
}),
},
)(SessionDetails),
);
38 changes: 1 addition & 37 deletions pkg/ui/workspaces/cluster-ui/src/sessions/sessionsPageConnected.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

import { RouteComponentProps, withRouter } from "react-router-dom";
import { connect } from "react-redux";
import { analyticsActions, AppState } from "src/store";
import { AppState } from "src/store";
import { SessionsState } from "src/store/sessions";

import { createSelector } from "reselect";
Expand Down Expand Up @@ -103,50 +103,14 @@ export const SessionsPageConnected = withRouter(
columnName: string,
ascending: boolean,
) => {
dispatch(
analyticsActions.track({
name: "Column Sorted",
page: "Sessions",
tableName,
columnName,
}),
);
dispatch(
localStorageActions.update({
key: "sortSetting/SessionsPage",
value: { columnTitle: columnName, ascending: ascending },
}),
);
},
onSessionClick: () => {
dispatch(
analyticsActions.track({
name: "Session Clicked",
page: "Sessions",
}),
);
},
onTerminateSessionClick: () =>
analyticsActions.track({
name: "Session Actions Clicked",
page: "Sessions",
action: "Cancel Session",
}),
onTerminateStatementClick: () =>
analyticsActions.track({
name: "Session Actions Clicked",
page: "Sessions",
action: "Cancel Statement",
}),
onFilterChange: (value: Filters) => {
dispatch(
analyticsActions.track({
name: "Filter Clicked",
page: "Sessions",
filterName: "app",
value: value.toString(),
}),
);
dispatch(
localStorageActions.update({
key: "filters/SessionsPage",
Expand Down
47 changes: 0 additions & 47 deletions pkg/ui/workspaces/cluster-ui/src/statementDetails/statementDetailsConnected.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ import {
actions as statementDiagnosticsActions,
selectDiagnosticsReportsByStatementFingerprint,
} from "src/store/statementDiagnostics";
import { actions as analyticsActions } from "src/store/analytics";
import { actions as localStorageActions } from "src/store/localStorage";
import { actions as nodesActions } from "../store/nodes";
import { actions as nodeLivenessActions } from "../store/liveness";
Expand Down Expand Up @@ -121,30 +120,7 @@ const mapDispatchToProps = (
}),
),
);
dispatch(
analyticsActions.track({
name: "Statement Diagnostics Clicked",
page: "Statement Details",
action: "Activated",
}),
);
},
onTabChanged: tabName =>
dispatch(
analyticsActions.track({
name: "Tab Changed",
page: "Statement Details",
tabName,
}),
),
onDiagnosticBundleDownload: () =>
dispatch(
analyticsActions.track({
name: "Statement Diagnostics Clicked",
page: "Statement Details",
action: "Downloaded",
}),
),
onDiagnosticCancelRequest: (report: IStatementDiagnosticsReport) => {
dispatch(
statementDiagnosticsActions.cancelReport(
Expand All @@ -153,13 +129,6 @@ const mapDispatchToProps = (
}),
),
);
dispatch(
analyticsActions.track({
name: "Statement Diagnostics Clicked",
page: "Statement Details",
action: "Cancelled",
}),
);
},
onStatementDetailsQueryChange: (latestQuery: string) => {
dispatch(sqlDetailsStatsActions.setLatestQuery(latestQuery));
Expand All @@ -169,22 +138,6 @@ const mapDispatchToProps = (
sqlDetailsStatsActions.setLatestFormattedQuery(latestFormattedQuery),
);
},
onSortingChange: (tableName, columnName) =>
dispatch(
analyticsActions.track({
name: "Column Sorted",
page: "Statement Details",
columnName,
tableName,
}),
),
onBackToStatementsClick: () =>
dispatch(
analyticsActions.track({
name: "Back Clicked",
page: "Statement Details",
}),
),
});

export const ConnectedStatementDetailsPage = withRouter<any, any>(
Expand Down
54 changes: 1 addition & 53 deletions pkg/ui/workspaces/cluster-ui/src/statementsPage/statementsPageConnected.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import { Dispatch } from "redux";

import { AppState, uiConfigActions } from "src/store";
import { actions as statementDiagnosticsActions } from "src/store/statementDiagnostics";
import { actions as analyticsActions } from "src/store/analytics";
import {
actions as localStorageActions,
updateStmtsPageLimitAction,
Expand Down Expand Up @@ -134,49 +133,21 @@ export const ConnectedStatementsPage = withRouter(
}),
),
);
dispatch(
analyticsActions.track({
name: "Statement Diagnostics Clicked",
page: "Statements",
action: "Activated",
}),
);
},
onSelectDiagnosticsReportDropdownOption: (
report: IStatementDiagnosticsReport,
) => {
if (report.completed) {
dispatch(
analyticsActions.track({
name: "Statement Diagnostics Clicked",
page: "Statements",
action: "Downloaded",
}),
);
} else {
if (!report.completed) {
dispatch(
statementDiagnosticsActions.cancelReport(
new CancelStatementDiagnosticsReportRequest({
request_id: report.id,
}),
),
);
dispatch(
analyticsActions.track({
name: "Statement Diagnostics Clicked",
page: "Statements",
action: "Cancelled",
}),
);
}
},
onSearchComplete: (query: string) => {
dispatch(
analyticsActions.track({
name: "Keyword Searched",
page: "Statements",
}),
);
dispatch(
localStorageActions.update({
key: "search/StatementsPage",
Expand All @@ -185,14 +156,6 @@ export const ConnectedStatementsPage = withRouter(
);
},
onFilterChange: value => {
dispatch(
analyticsActions.track({
name: "Filter Clicked",
page: "Statements",
filterName: "app",
value: value.toString(),
}),
);
dispatch(
localStorageActions.update({
key: "filters/StatementsPage",
Expand All @@ -205,28 +168,13 @@ export const ConnectedStatementsPage = withRouter(
columnName: string,
ascending: boolean,
) => {
dispatch(
analyticsActions.track({
name: "Column Sorted",
page: "Statements",
tableName,
columnName,
}),
);
dispatch(
localStorageActions.update({
key: "sortSetting/StatementsPage",
value: { columnTitle: columnName, ascending: ascending },
}),
);
},
onStatementClick: () =>
dispatch(
analyticsActions.track({
name: "Statement Clicked",
page: "Statements",
}),
),
// We use `null` when the value was never set and it will show all columns.
// If the user modifies the selection and no columns are selected,
// the function will save the value as a blank space, otherwise
Expand Down
95 changes: 0 additions & 95 deletions pkg/ui/workspaces/cluster-ui/src/store/analytics/analytics.reducer.ts
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions pkg/ui/workspaces/cluster-ui/src/store/analytics/index.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion pkg/ui/workspaces/cluster-ui/src/store/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,5 @@

export { sagas } from "./sagas";
export { notificationAction } from "./notifications";
export { actions as analyticsActions } from "./analytics";
export { actions as uiConfigActions, UIConfigState } from "./uiConfig";
export { rootReducer, AppState, rootActions } from "./reducers";
Loading
Loading