remove phone-home diagnostics, update checks, crash reports#65
Merged
iliana merged 6 commits intorelease-22.1-oxidefrom Mar 17, 2026
Merged
remove phone-home diagnostics, update checks, crash reports#65iliana merged 6 commits intorelease-22.1-oxidefrom
iliana merged 6 commits intorelease-22.1-oxidefrom
Conversation
iliana
force-pushed
the
iliana/no-phone-home
branch
from
8a5799e to
2ee4fb3
Compare
iliana
force-pushed
the
iliana/no-phone-home
branch
from
2ee4fb3 to
45d7f04
Compare
iliana
changed the title
Collaborator
Author
|
I need to test that we can safely move back and forth between clusters with and without this change, since we're removing three cluster options. But given that a handful of options were apparently removed in v22.1.2 I think it's likely fine. |
sudomateo
approved these changes
Mar 17, 2026
sudomateo
left a comment
sudomateo
left a comment
There was a problem hiding this comment.
This looks good for me overall. Just left a question about one of the changes but it's non-blocking.
iliana
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Mar 20, 2026
Primarily for debugging (#9427, and time sync problems). The vast majority of changes here are build system related or updating dependencies that are used in tests only, but there are some actual code changes worth pointing out: - oxidecomputer/cockroach#46 (r+ @sudomateo) - oxidecomputer/pebble@e7c3451 "fix lints; run tests in buildomat" (not reviewed) - oxidecomputer/pebble@06125d2 backport of "sstable: do a bit flip computation on a checksum mismatch in the Reader" (not reviewed) - oxidecomputer/cockroach#60 (@JustinAzoff; r+ @iliana) - oxidecomputer/cockroach#64 (not reviewed) - oxidecomputer/cockroach#65 (r+ @sudomateo) Full delta: oxidecomputer/cockroach@367bca4...86fdbfc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes phone-home diagnostics reporting, update checking, and crash reporting. Fixes #48.
Web console analytics and update checking was removed in #64.
The ability to produce a diagnostics report (and testing of these paths) are kept, as I think users can still manually create diagnostic reports via the HTTP API. Similarly most crash handling code paths are kept, but with the crash reporting removed.