Improve ignition target selection in faux-mgs
#467
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignition commands in
faux-mgsrequire specifying an "ignition target", which has to be looked up in RFD 144 § Switch port map. This isn't the same as cubby number, which is annoying.This PR makes it easier to deal with:
This set of arguments is common to
ignition,ignition-link-events,clear-ignition-link-events;ignition-commandsupports all the flags except--all.Opening as a draft because
racktestusesfaux-mgs ignition allhere, and we should figure out how to coordinate with its release. We could keepallas a special-cased target (instead of--all), but it's kinda annoying...