Add transit_ips to NIC create body
#8851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-crespo
commented
Aug 18, 2025
| @@ -1260,6 +1272,8 @@ impl QueryFragment<Pg> for InsertQueryValues { | |||
| out.push_identifier(dsl::slot::NAME)?; | |||
| out.push_sql(", "); | |||
| out.push_identifier(dsl::is_primary::NAME)?; | |||
| out.push_sql(", "); | |||
| out.push_identifier(dsl::transit_ips::NAME)?; | |||
There was a problem hiding this comment.
The changes in this file are the ones most likely to have issues, but the test suggests they are working.
There was a problem hiding this comment.
As above, I do think they are correct here.
david-crespo
force-pushed
the
nic-transit-ips
branch
from
5ed0a7e to
7a34d67
Compare
Comment on lines
3253
to
3268
| // Verify transit IPs are correctly persisted | ||
| assert_eq!( | ||
| inserted_interface.transit_ips.len(), | ||
| transit_ips.len(), | ||
| "Transit IPs count should match" | ||
| ); | ||
|
|
||
| for (actual, expected) in | ||
| inserted_interface.transit_ips.iter().zip(transit_ips.iter()) | ||
| { | ||
| assert_eq!( | ||
| actual, expected, | ||
| "Transit IP {} should match expected {}", | ||
| actual, expected | ||
| ); | ||
| } |
There was a problem hiding this comment.
This has already been verified by assert_interfaces_eq, right?
Comment on lines
2741
to
2746
| assert_eq!(iface.transit_ips.len(), params.transit_ips.len()); | ||
| for (actual, expected) in | ||
| iface.transit_ips.iter().zip(params.transit_ips.iter()) | ||
| { | ||
| assert_eq!(actual, expected); | ||
| } |
There was a problem hiding this comment.
Suggested change
| assert_eq!(iface.transit_ips.len(), params.transit_ips.len()); | |
| for (actual, expected) in | |
| iface.transit_ips.iter().zip(params.transit_ips.iter()) | |
| { | |
| assert_eq!(actual, expected); | |
| } | |
| assert_eq!(iface.transit_ips, params.transit_ips); |
This should suffice? I guess that's two places Claude has chosen to break up an equality test like this. 😅
Comment on lines
+1216
to
+1220
| out.push_bind_param::<sql_types::Array<sql_types::Inet>, Vec<IpNetwork>>( | ||
| &self.interface.transit_ips, | ||
| )?; | ||
| out.push_sql(" AS "); | ||
| out.push_identifier(dsl::transit_ips::NAME)?; |
There was a problem hiding this comment.
This should probably reflected in the doc comment on lines 923--930, but otherwise it looks correct to me.
| @@ -1260,6 +1272,8 @@ impl QueryFragment<Pg> for InsertQueryValues { | |||
| out.push_identifier(dsl::slot::NAME)?; | |||
| out.push_sql(", "); | |||
| out.push_identifier(dsl::is_primary::NAME)?; | |||
| out.push_sql(", "); | |||
| out.push_identifier(dsl::transit_ips::NAME)?; | |||
There was a problem hiding this comment.
As above, I do think they are correct here.
This was referenced Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6588
As threatened in product eng sync, here is Claude with some aggressive steering on my end. It cost nearly $10, by far the most I have ever spent in Claude Code. Hard to say whether it was worth it. It seems pretty good and I did almost nothing.