[perf-cleanup] remove redundant tests and update mcast polling #9547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeeshanlakhani
force-pushed
the
zl/mcast-test-perf
branch
from
6cd91a1 to
e7d1504
Compare
Combine similar [nexus_tests] for mcast, while being more thoughtful on failure handling and polling.
zeeshanlakhani
force-pushed
the
zl/mcast-test-perf
branch
from
e7d1504 to
16b8f12
Compare
zeeshanlakhani
requested review from
internet-diglett,
rcgoodfellow and
smklein
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some test redundancy in the multicast suite and tries to make convergence faster for integration RPW testing.
I was spurred on to tackle this by way of #9536. While this doesn't fully restore pre-multicast-introduced test times (likely due to more complete end-to-end network testing), it does reduce tail-end outliers when I run the
histtool against this branch.I do think we need to rethink our nexus testing suite altogether, though. Nonetheless, I think this should help some.
Note: I'm putting this post #9450 due to source handling involving many test changes from
main.