Skip to content

Conversation

@wfchandler
Copy link
Contributor

Allow users to specify additional trait bounds on CliConfig methods.

Allow users to specify additional trait bounds on `CliConfig` methods.
@ahl
Copy link
Collaborator

ahl commented Sep 18, 2025

I'm not a huge fan of this--the whole point of including JsonSchema as a trait bound was to satisfy this use case. If it's not useful then perhaps we remove it.

@wfchandler
Copy link
Contributor Author

wfchandler commented Sep 19, 2025

I'm not a huge fan of this--the whole point of including JsonSchema as a trait bound was to satisfy this use case. If it's not useful then perhaps we remove it.

@ahl removing the JsonSchema bound would be a breaking change for some of our projects that generate a CLI, rfd-api is a public example, but there are several internal repos as well. JsonSchema is clearly useful in some scenarios, but I think the type reflection in oxidecomputer/oxide.rs#1221 is simpler with the proc macro approach.

@ahl ahl merged commit 957afea into main Sep 19, 2025
9 checks passed
@ahl ahl deleted the wc/cli-bounds branch September 19, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants