Mixed changes #53
Mixed changes #53
Conversation
load_tiff() does pretty much the exact same as from_file()
only appropriate for NS-EW aligned raster but I guess thats true for the whole code base
ozak
left a comment
ozak
left a comment
There was a problem hiding this comment.
What is the benefit of this? Just wondering? Less memory?
ozak
left a comment
ozak
left a comment
There was a problem hiding this comment.
Not sure which duplication you refer to. The function is defined only once.
| self.geot = geot | ||
| self.nodata_value = nodata_value |
There was a problem hiding this comment.
Would there be a reason to not use the @property for the other properties?
There was a problem hiding this comment.
There's no need, unless you want to add e.g. type checks when these get set.
Main reason to make those other attributes into properties is, they are derived values and should not be stored by itself but rather looked up from their "parents".
|
Thanks for taking the time! If you are able to finish these let me know and I will merge the PR soon. |
Somehow this comment is not linked to code, so not sure what change you were commenting on.. |
2 participants
WIP - DO NOT MERGE