fix db and collection operations and returning obj instead of array#44
Open
586837r wants to merge 1 commit intoozomer:masterfrom
Open
fix db and collection operations and returning obj instead of array#44586837r wants to merge 1 commit intoozomer:masterfrom
586837r wants to merge 1 commit intoozomer:masterfrom
Conversation
Author
|
fixes #37 |
Contributor
|
I was looking into a fix too, and thought it would have been better to check whether 'response' is an array at that point, rather than hard-coding the methods... didn't have the time to do testing as I don't have a working nodered build right now. Also, this will REQUIRE a docs entry & a full-version bump to 3.0 as this significantly changes behaviour and might break people's flows who have worked around the issue. (node-red won't automatically update a module acoss a major version, but will with a minor bump) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cloning the response breaks db and collection instances
not sure if this is a good way to fix it but it works