Skip to content

fix db and collection operations and returning obj instead of array#44

Open
586837r wants to merge 1 commit intoozomer:masterfrom
586837r:master
Open

fix db and collection operations and returning obj instead of array#44
586837r wants to merge 1 commit intoozomer:masterfrom
586837r:master

Conversation

@586837r
Copy link

@586837r 586837r commented Feb 6, 2020

cloning the response breaks db and collection instances
not sure if this is a good way to fix it but it works

@586837r
Copy link
Author

586837r commented Feb 6, 2020

fixes #37

@586837r 586837r changed the title fix db and collection operations fix db and collection operations and returning obj instead of array Feb 6, 2020
@jomel
Copy link
Contributor

jomel commented Feb 6, 2020

I was looking into a fix too, and thought it would have been better to check whether 'response' is an array at that point, rather than hard-coding the methods... didn't have the time to do testing as I don't have a working nodered build right now.

Also, this will REQUIRE a docs entry & a full-version bump to 3.0 as this significantly changes behaviour and might break people's flows who have worked around the issue. (node-red won't automatically update a module acoss a major version, but will with a minor bump)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants