Skip to content

Added widget minimize/restore button to frame, and app toolbar.#1

Open
FlushedCrusher wants to merge 1 commit intoozoneplatform:masterfrom
FlushedCrusher:master
Open

Added widget minimize/restore button to frame, and app toolbar.#1
FlushedCrusher wants to merge 1 commit intoozoneplatform:masterfrom
FlushedCrusher:master

Conversation

@FlushedCrusher
Copy link

This pull request implements a minimize and restore functionality to the webtop.

Existing OZP features were used to add a minimize button to widget toolbar.
Clicking the minimize button minimizes the widget. Clicking the widget icon in the desktop toolbar footer will restore the widget.

Similarly, clicking the widget icon in the desktop toolbar footer will act as a toggle for the minimized state of the widget.

@rpokorny
Copy link

rpokorny commented Sep 15, 2016

Congratulations on submitting OZP's first community PR!

There are a few things that we will be requiring from all PRs:

  1. Automated tests (if applicable). I notice that your code currently does not have any.
  2. Documentation. In this case some screenshots with descriptions would be sufficient.
  3. A description of manual test cases for exercising the feature.

We will discuss your PR at a review meeting next week.

@rpokorny
Copy link

If you want the review board to be able to attribute this contribution to you or your group, please email me identifying information such as your name, company/agency, and project. My email is ross dot pokorny at nextcentury dot com.

@FlushedCrusher
Copy link
Author

FlushedCrusher commented Oct 12, 2016

minimize-restore

Manual Test Cases

Test Minimize

  • Launch WebTop
  • Add a widget to the WebTop
  • Click Minimize button in chrome of widget
  • Expect widget to be minimized

Test Restore

  • [Following Minimize Test]
  • Click Widget icon in WebTop footer
  • Expect Widget to be restored

Test Toggle

  • [Following Restore Test]
  • Click Widget icon in WebTop footer
  • Expect widget to be minimized
  • Click Widget icon in WebTop footer
  • Expect Widget to be restored

@mparizernc
Copy link

@FlushedCrusher We plan to present this request for community testing at the end of the month to the GOSS Board. I wanted to reach out and see if you were willing to provide your name and/or group to the board for credit. If so please email me at mike.parizer@nextcentury.com. Otherwise we will leave the request as anonymous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants