-
Notifications
You must be signed in to change notification settings - Fork 8
Bug fixes, adaptation to the current specification, and new features #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LUGGGI
wants to merge
61
commits into
p2o-lab:master
Choose a base branch
from
LUGGGI:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct handshake for Op commands
…odeActiveElements
… Plus some refactoring
…arting state completed to fast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I used this package for my master’s thesis and updated many parts of it.
I tried not to change too much in terms of usage to allow existing systems to be updated easily.
In some cases, there were bugs or inconsistencies with the current MTP specifications, in those cases, I modified the code to comply with the latest specification.
The following is a list of the updates I made, in alphabetical order by the files changed.
It does not include refactoring or the addition of comments and type hints.
Added new examples to demonstrate both new and existing functionalities
Updated existing examples to work with the latest changes
Added a new architecture class diagram
ActiveElements:
OperationModeforBinVlv.set_value(False)instead of.value = FalseAttribute: Added methods for adding/removing sub-callbacks
CommandEnControl: Hold and pause disabled by default
Disabled restart when no valid procedure is set
OPCUAServerPEA:
_build_opcua_server,_create_opcua_objects_for_folders, and_create_opcua_objects_for_leavesMoved
ParameterElementsto the correct file and added theOperationElementsimplementationoperation_source_mode:
OperationSourceModeto anotherOperationModeandSourceModeclasses for the elementsProcedureControl: Improved resetting of procedure commands
Service:
CommandEnwhen changing operation modeis_statenow works for edge casesstate_stop_eventFixed incorrect state code
StateMachine: Reset the command operation code and updated functions to refresh
CommandEnanddisable_commands_if_no_proceduresuc_data_assembly: Added abstract methods and
SUCParameterElementthread_control:
StoppableThreadclass that can be stopped by setting an eventexception_callback